Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #3]

2015-06-22 Thread Paul Moore
On Mon, Jun 22, 2015 at 5:41 AM, David Howells wrote: > Paul Moore wrote: > >> This patch looks fine to me and I think there is an advantage to merging this >> regardless of what happens with the "unioning" work so I'm inclined to queue >> this up now unless you would prefer to resubmit with the

Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #3]

2015-06-22 Thread David Howells
Paul Moore wrote: > This patch looks fine to me and I think there is an advantage to merging this > regardless of what happens with the "unioning" work so I'm inclined to queue > this up now unless you would prefer to resubmit with the union patches? If you could queue it up now, that'd be gre

Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #3]

2015-06-18 Thread Paul Moore
On Thursday, June 18, 2015 07:25:05 PM David Howells wrote: > Create a common helper function to determine the label for a new inode. > This is then used by: > > - may_create() > - selinux_dentry_init_security() > - selinux_inode_init_security() > > This will change the behaviou

Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #3]

2015-06-18 Thread Stephen Smalley
On 06/18/2015 02:25 PM, David Howells wrote: > > Create a common helper function to determine the label for a new inode. > This is then used by: > > - may_create() > - selinux_dentry_init_security() > - selinux_inode_init_security() > > This will change the behaviour of the

[PATCH] SELinux: Create a common helper to determine an inode label [ver #3]

2015-06-18 Thread David Howells
Create a common helper function to determine the label for a new inode. This is then used by: - may_create() - selinux_dentry_init_security() - selinux_inode_init_security() This will change the behaviour of the functions slightly, bringing them all into line. Sugges

Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2]

2015-06-18 Thread David Howells
Stephen Smalley wrote: > >> + rc = selinux_determine_inode_label(d_inode(dentry), name, > > > > We want d_inode(dentry->d_parent) here. > > Not sure why the caller didn't just pass in the dir inode in the first > place. Might be something in one of the other LSMs? David -- To unsubscribe fro

Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2]

2015-06-18 Thread David Howells
Stephen Smalley wrote: > > + rc = selinux_determine_inode_label(d_inode(dentry), name, > > We want d_inode(dentry->d_parent) here. Aargh. I forgot to commit it. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2]

2015-06-18 Thread Stephen Smalley
On 06/18/2015 01:08 PM, Stephen Smalley wrote: > On 06/18/2015 12:41 PM, David Howells wrote: >> SELinux: Create a common helper to determine an inode label >> >> Create a common helper function to determine the label for a new inode. >> This is then used by: >> >> - may_create() >> - sel

Re: [PATCH] SELinux: Create a common helper to determine an inode label [ver #2]

2015-06-18 Thread Stephen Smalley
On 06/18/2015 12:41 PM, David Howells wrote: > SELinux: Create a common helper to determine an inode label > > Create a common helper function to determine the label for a new inode. > This is then used by: > > - may_create() > - selinux_dentry_init_security() > - selinux_inode_

Re: [PATCH] SELinux: Create a common helper to determine an inode label

2015-06-18 Thread David Howells
Stephen Smalley wrote: > > + rc = selinux_determine_inode_label(d_inode(dentry), name, > > Hmmm...previously we were using d_backing_inode(dentry->d_parent) here. I also think this should probably be d_inode() not d_backing_inode() since we're being called by the filesystem that owns the dent

[PATCH] SELinux: Create a common helper to determine an inode label [ver #2]

2015-06-18 Thread David Howells
SELinux: Create a common helper to determine an inode label Create a common helper function to determine the label for a new inode. This is then used by: - may_create() - selinux_dentry_init_security() - selinux_inode_init_security() This will change the behaviour of the

Re: [PATCH] SELinux: Create a common helper to determine an inode label

2015-06-18 Thread David Howells
Stephen Smalley wrote: > > + rc = selinux_determine_inode_label(d_inode(dentry), name, > > Hmmm...previously we were using d_backing_inode(dentry->d_parent) here. You're right. In changing between various sorts of dentry and inode I've lost one of the subtleties. David -- To unsubscribe fro

Re: [PATCH] SELinux: Create a common helper to determine an inode label

2015-06-18 Thread Stephen Smalley
On 06/18/2015 12:19 PM, David Howells wrote: > > Create a common helper function to determine the label for a new inode. > This is then used by: > > - may_create() > - selinux_dentry_init_security() > - selinux_inode_init_security() > > This will change the behaviour of the

[PATCH] SELinux: Create a common helper to determine an inode label

2015-06-18 Thread David Howells
Create a common helper function to determine the label for a new inode. This is then used by: - may_create() - selinux_dentry_init_security() - selinux_inode_init_security() This will change the behaviour of the functions slightly, bringing them all into line. Sugges