Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread Johannes Thumshirn
On Fri, Aug 12, 2016 at 07:54:03AM -0700, James Bottomley wrote: > On Fri, 2016-08-12 at 16:39 +0200, Hannes Reinecke wrote: > > On 08/12/2016 04:34 PM, James Bottomley wrote: > > > On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > > > > On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johann

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread James Bottomley
On Fri, 2016-08-12 at 16:39 +0200, Hannes Reinecke wrote: > On 08/12/2016 04:34 PM, James Bottomley wrote: > > On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > > > On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn > > > wrote: > > > > Ok, we can't use the rphy because of wi

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread Hannes Reinecke
On 08/12/2016 04:34 PM, James Bottomley wrote: > On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: >> On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn wrote: >>> Ok, we can't use the rphy because of wide-ports. We can't fix it to >>> an end device either, as this makes some

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread James Bottomley
On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn wrote: > > Ok, we can't use the rphy because of wide-ports. We can't fix it to > > an end device either, as this makes some peoples systems > > unbootable. Now let's find a

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread Johannes Thumshirn
On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn wrote: > On Thu, Aug 11, 2016 at 11:00:07AM -0700, James Bottomley wrote: > > On Thu, 2016-08-11 at 18:43 +0200, Johannes Thumshirn wrote: > > > On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote: > > > > On Thu, 2016-08-11 a

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-12 Thread Johannes Thumshirn
On Thu, Aug 11, 2016 at 11:00:07AM -0700, James Bottomley wrote: > On Thu, 2016-08-11 at 18:43 +0200, Johannes Thumshirn wrote: > > On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote: > > > On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote: > > > > Since commit 3f8d6f2a0 ('se

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-11 Thread James Bottomley
On Thu, 2016-08-11 at 18:43 +0200, Johannes Thumshirn wrote: > On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote: > > On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote: > > > Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in > > > SAS > > > enclosures') ses_matc

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-11 Thread Johannes Thumshirn
On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote: > On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote: > > Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS > > enclosures') ses_match_to_enclosure() is calling sas_get_address(), > > which is coming from com

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-11 Thread James Bottomley
On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote: > Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS > enclosures') ses_match_to_enclosure() is calling sas_get_address(), > which is coming from commit bcf508c13385 ('scsi_transport_sas: add > function to get SAS endpoint

[PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

2016-08-11 Thread Johannes Thumshirn
Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS enclosures') ses_match_to_enclosure() is calling sas_get_address(), which is coming from commit bcf508c13385 ('scsi_transport_sas: add function to get SAS endpoint address'). sas_get_address() itself calls sas_sdev_to_rdev() which B