Re: [PATCH] Revert "mmc: sdhci-xenon: add runtime pm support and reimplement standby"

2020-05-15 Thread Ulf Hansson
On Fri, 15 May 2020 at 08:00, Jisheng Zhang wrote: > > On Thu, 14 May 2020 12:18:58 +0200 Ulf Hansson wrote: > > > > > > > On Thu, 14 May 2020 at 07:45, Jisheng Zhang > > wrote: > > > > > > On Wed, 13 May 2020 14:15:21 +0200 Ulf Hansson wrote: > > > > > > > > > > > > > > > On Wed, 13 May 2020 at

Re: [PATCH] Revert "mmc: sdhci-xenon: add runtime pm support and reimplement standby"

2020-05-14 Thread Jisheng Zhang
On Thu, 14 May 2020 12:18:58 +0200 Ulf Hansson wrote: > > > On Thu, 14 May 2020 at 07:45, Jisheng Zhang > wrote: > > > > On Wed, 13 May 2020 14:15:21 +0200 Ulf Hansson wrote: > > > > > > > > > > > On Wed, 13 May 2020 at 11:47, Jisheng Zhang > > > wrote: > > > > > > > > This reverts commi

Re: [PATCH] Revert "mmc: sdhci-xenon: add runtime pm support and reimplement standby"

2020-05-14 Thread Ulf Hansson
On Thu, 14 May 2020 at 07:45, Jisheng Zhang wrote: > > On Wed, 13 May 2020 14:15:21 +0200 Ulf Hansson wrote: > > > > > > > On Wed, 13 May 2020 at 11:47, Jisheng Zhang > > wrote: > > > > > > This reverts commit a027b2c5fed78851e69fab395b02d127a7759fc7. > > > > > > The HW supports auto clock gatin

Re: [PATCH] Revert "mmc: sdhci-xenon: add runtime pm support and reimplement standby"

2020-05-13 Thread Jisheng Zhang
On Wed, 13 May 2020 14:15:21 +0200 Ulf Hansson wrote: > > > On Wed, 13 May 2020 at 11:47, Jisheng Zhang > wrote: > > > > This reverts commit a027b2c5fed78851e69fab395b02d127a7759fc7. > > > > The HW supports auto clock gating, so it's useless to do runtime pm > > in software. > > Runtime PM

Re: [PATCH] Revert "mmc: sdhci-xenon: add runtime pm support and reimplement standby"

2020-05-13 Thread Ulf Hansson
On Wed, 13 May 2020 at 11:47, Jisheng Zhang wrote: > > This reverts commit a027b2c5fed78851e69fab395b02d127a7759fc7. > > The HW supports auto clock gating, so it's useless to do runtime pm > in software. Runtime PM isn't soley about clock gating. Moreover it manages the "pltfm_host->clk", which m

[PATCH] Revert "mmc: sdhci-xenon: add runtime pm support and reimplement standby"

2020-05-13 Thread Jisheng Zhang
This reverts commit a027b2c5fed78851e69fab395b02d127a7759fc7. The HW supports auto clock gating, so it's useless to do runtime pm in software. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci-xenon.c | 87 +++--- drivers/mmc/host/sdhci-xenon.h | 1 - 2 files