Re: [PATCH] Restore gcc check in mips asm/unroll.h

2020-07-10 Thread Nathan Chancellor
On Fri, Jul 10, 2020 at 03:31:00PM -0700, Linus Torvalds wrote: > On Fri, Jul 10, 2020 at 11:43 AM Nick Desaulniers > wrote: > > > > What I'd really like to see as a policy in the kernel going forward in > > that ANY new commit that adds some hack or workaround for a specific > > compiler version

Re: [PATCH] Restore gcc check in mips asm/unroll.h

2020-07-10 Thread Linus Torvalds
On Fri, Jul 10, 2020 at 11:43 AM Nick Desaulniers wrote: > > What I'd really like to see as a policy in the kernel going forward in > that ANY new commit that adds some hack or workaround for a specific > compiler version add a comment about which toolchain version was > problematic, that way when

Re: [PATCH] Restore gcc check in mips asm/unroll.h

2020-07-10 Thread Nick Desaulniers
On Thu, Jul 9, 2020 at 5:53 PM Linus Torvalds wrote: > > On Thu, Jul 9, 2020 at 3:11 PM Cesar Eduardo Barros > wrote: > > > > While raising the gcc version requirement to 4.9, the compile-time check > > in the unroll macro was accidentally changed from being used on gcc and > > clang to being use

[PATCH] Restore gcc check in mips asm/unroll.h

2020-07-09 Thread Cesar Eduardo Barros
While raising the gcc version requirement to 4.9, the compile-time check in the unroll macro was accidentally changed from being used on gcc and clang to being used on clang only. Restore the gcc check, changing it from "gcc >= 4.7" to "all gcc". Fixes: 6ec4476ac825 ("Raise gcc version requiremen

Re: [PATCH] Restore gcc check in mips asm/unroll.h

2020-07-09 Thread Linus Torvalds
On Thu, Jul 9, 2020 at 3:11 PM Cesar Eduardo Barros wrote: > > While raising the gcc version requirement to 4.9, the compile-time check > in the unroll macro was accidentally changed from being used on gcc and > clang to being used on clang only. > > Restore the gcc check, changing it from "gcc >=