Re: [PATCH] Restore PWC driver

2005-03-08 Thread Martin Hicks
On Tue, Mar 08, 2005 at 04:59:38AM -0500, Alan Cox wrote: > On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote: > > > So, who's going to fix up: > > - the MAINTAINERS entry > > - the coding style > > - drop that unneeded changelog file > > - fix the module help text to point

Re: [PATCH] Restore PWC driver

2005-03-08 Thread Andrew Morton
Alan Cox <[EMAIL PROTECTED]> wrote: > > On Tue, Mar 08, 2005 at 05:34:06AM +, Christoph Hellwig wrote: > > Agree with greg on all these bits, and similar (although not as bad) for > > the other bits Alan sent. Alan, could you please go through the subsystem > > maintainer & -mm process lik

Re: [PATCH] Restore PWC driver

2005-03-08 Thread Alan Cox
On Tue, Mar 08, 2005 at 05:34:06AM +, Christoph Hellwig wrote: > Agree with greg on all these bits, and similar (although not as bad) for > the other bits Alan sent. Alan, could you please go through the subsystem > maintainer & -mm process like everyone else? A little public review > can't h

Re: [PATCH] Restore PWC driver

2005-03-08 Thread Alan Cox
On Mon, Mar 07, 2005 at 09:32:19PM -0800, Greg KH wrote: > So, who should I be bouncing the emails that I'm about to get from the > angry mob of ppc users/developers that always throw large, blunt objects > at me whenever I add code that breaks on their machines? Relax dude. Lets have a plan and a

Re: [PATCH] Restore PWC driver

2005-03-08 Thread Alan Cox
On Tue, Mar 08, 2005 at 09:15:08AM +0100, Luc Saillard wrote: > > - the coding style > oops (anyone have a vim syntax file for lkml indenting ?) indent -kr -i8 -bri0 -l255 comes very close as a starter. If you do that don't mix it with any actual code changes. > > - drop that unneeded c

Re: [PATCH] Restore PWC driver

2005-03-08 Thread Alan Cox
On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote: > As it is, the coding style sucks in places, and you didn't really need > to make it a new subdirectory (although due to the increased size of the > driver, it's probably better now...) Luc I assume > And, there's no MAINTAINERS entry for

Re: [PATCH] Restore PWC driver

2005-03-08 Thread Luc Saillard
On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote: > On Mon, Mar 07, 2005 at 09:49:40PM +, Linux Kernel Mailing List wrote: > > ChangeSet 1.1982.132.4, 2005/03/07 13:49:40-08:00, [EMAIL PROTECTED] > > > > [PATCH] Restore PWC driver > > > >

Re: [PATCH] Restore PWC driver

2005-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote: > Ick, Alan, couldn't you have had the decency to run this through the USB > developers, and at least pinged me on it? Especially due to all of the > hate-email I have gotten over this driver in the past. > > As it is, the coding style suck

Re: [PATCH] Restore PWC driver

2005-03-07 Thread Greg KH
On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote: > So, who's going to fix up: Add: - the sparse warnings. to that list. Oh, and those sparse warnings show that this driver is now completely broken on big-endian boxes. So, who should I be bouncing the emails that I'm about to get

Re: [PATCH] Restore PWC driver

2005-03-07 Thread Greg KH
On Mon, Mar 07, 2005 at 09:49:40PM +, Linux Kernel Mailing List wrote: > ChangeSet 1.1982.132.4, 2005/03/07 13:49:40-08:00, [EMAIL PROTECTED] > > [PATCH] Restore PWC driver > > PWC has a new maintainer (Luc Saillard) and also the various contentious >