Re: [PATCH] Remove suspend() calls from shutdown path

2005-08-04 Thread Rafael J. Wysocki
On Thursday, 4 of August 2005 22:58, you wrote: > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > On Thursday, 4 of August 2005 17:20, Benjamin Herrenschmidt wrote: > > > On Thu, 2005-08-04 at 15:16 +0300, Zilvinas Valinskas wrote: > > > > Hello Ben, Andrew, > > > > > > > > This patch help

Re: [PATCH] Remove suspend() calls from shutdown path

2005-08-04 Thread Andrew Morton
"Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > On Thursday, 4 of August 2005 17:20, Benjamin Herrenschmidt wrote: > > On Thu, 2005-08-04 at 15:16 +0300, Zilvinas Valinskas wrote: > > > Hello Ben, Andrew, > > > > > > This patch helps me if I disconnect all USB peripherals before shutting > > >

Re: [PATCH] Remove suspend() calls from shutdown path

2005-08-04 Thread Rafael J. Wysocki
On Thursday, 4 of August 2005 17:20, Benjamin Herrenschmidt wrote: > On Thu, 2005-08-04 at 15:16 +0300, Zilvinas Valinskas wrote: > > Hello Ben, Andrew, > > > > This patch helps me if I disconnect all USB peripherals before shutting > > down notebook. With connected peripherals (USB mouse, PL2303

Re: [PATCH] Remove suspend() calls from shutdown path

2005-08-04 Thread Zilvinas Valinskas
On Thu, 2005-08-04 at 17:20 +0200, Benjamin Herrenschmidt wrote: > On Thu, 2005-08-04 at 15:16 +0300, Zilvinas Valinskas wrote: > > Hello Ben, Andrew, > > > > This patch helps me if I disconnect all USB peripherals before shutting > > down notebook. With connected peripherals (USB mouse, PL2303 >

Re: [PATCH] Remove suspend() calls from shutdown path

2005-08-04 Thread Benjamin Herrenschmidt
On Thu, 2005-08-04 at 15:16 +0300, Zilvinas Valinskas wrote: > Hello Ben, Andrew, > > This patch helps me if I disconnect all USB peripherals before shutting > down notebook. With connected peripherals (USB mouse, PL2303 > USB<->serial converter/port) - powering off process stops right after > un

Re: [PATCH] Remove suspend() calls from shutdown path

2005-08-04 Thread Zilvinas Valinskas
Hello Ben, Andrew, This patch helps me if I disconnect all USB peripherals before shutting down notebook. With connected peripherals (USB mouse, PL2303 USB<->serial converter/port) - powering off process stops right after unmounting filesystems but before hda power off ... There is a bug report

[PATCH] Remove suspend() calls from shutdown path

2005-08-04 Thread Benjamin Herrenschmidt
Hi Andrew ! This patch remove the calls to device_suspend() from the shutdown path that were added sometime during 2.6.13-rc*. They aren't working properly on a number of configs (I got reports from both ppc powerbook users and x86 users) causing the system to not shutdown anymore. I think it isn