Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > On Mon, 2005-08-01 at 23:03 +0200, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > > > - struct semaphore stop; > > > + struct compat_semaphore stop; > > > > i think it's policy->lock that is the issue here? > > > > I was

Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Steven Rostedt
On Mon, 2005-08-01 at 23:03 +0200, Ingo Molnar wrote: > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > - struct semaphore stop; > > + struct compat_semaphore stop; > > i think it's policy->lock that is the issue here? > I was looking at Luca's original message where he showed the bug of

Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > - struct semaphore stop; > + struct compat_semaphore stop; i think it's policy->lock that is the issue here? Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Ingo Molnar
* Luca Falavigna <[EMAIL PROTECTED]> wrote: > This patch fixes broken rt_init_MUTEX_LOCKED declaration using > rt_sema_init() macro. This way we fix a potential compile bug: > rt_init_MUTEX_LOCKED calls > there_is_no_init_MUTEX_LOCKED_for_RT_semaphores, which is not > referenced. (e.g. driver

Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Steven Rostedt
On Mon, 2005-08-01 at 12:13 -0700, Sven-Thorsten Dietrich wrote: > On Mon, 2005-08-01 at 19:05 +, Luca Falavigna wrote: > > > > > > Another solution could be this (as shown in drivers/cpufreq/cpufreq.c): > > - init_MUTEX_LOCKED(&policy->lock); > > + init_MUTEX(&policy->lock); > > + down(

Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Sven-Thorsten Dietrich
On Mon, 2005-08-01 at 19:05 +, Luca Falavigna wrote: > > The patch you wanted to send was: > > > > Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> > > > > Index: linux_realtime_ernie/drivers/char/watchdog/cpu5wdt.c > > === > >

Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Luca Falavigna
> Ingo purposely put this in to crash > the compile so that we know where this can be a problem right away. And it works nice ;) > The patch you wanted to send was: > > Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> > > Index: linux_realtime_ernie/drivers/char/watchdog/cpu5wdt.c > ===

Re: [PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Steven Rostedt
On Mon, 2005-08-01 at 16:26 +, Luca Falavigna wrote: > This patch fixes broken rt_init_MUTEX_LOCKED declaration using rt_sema_init() > macro. This way we fix a potential compile bug: rt_init_MUTEX_LOCKED calls > there_is_no_init_MUTEX_LOCKED_for_RT_semaphores, which is not referenced. > (e.g. d

[PATCH] Real-Time Preemption V0.7.52-07: rt_init_MUTEX_LOCKED declaration

2005-08-01 Thread Luca Falavigna
This patch fixes broken rt_init_MUTEX_LOCKED declaration using rt_sema_init() macro. This way we fix a potential compile bug: rt_init_MUTEX_LOCKED calls there_is_no_init_MUTEX_LOCKED_for_RT_semaphores, which is not referenced. (e.g. drivers/char/watchdog/cpu5wdt.c: "cpu5wdt: Unknown symbol there_is