[EMAIL PROTECTED] (Dan Aloni) writes:
> Is there a special reason why dev->name is not a pointer?
One of the changes in 2.3 was to change dev->name from a pointer to the
char array. A little bit painful (in terms of the number of changes,
rather than the complexity).
The reason for this is that
Date: Wed, 15 Nov 2000 02:59:36 +0200 (IST)
From: Dan Aloni <[EMAIL PROTECTED]>
On Tue, 14 Nov 2000, David S. Miller wrote:
> Then the compiler will start warning us :-)
I've also noticed that routing_ioctl() in arch/mips64/kernel/ioctl32.c
assumes the 16. Are those two platfo
On Tue, 14 Nov 2000, David S. Miller wrote:
>Date: Wed, 15 Nov 2000 02:25:38 +0200 (IST)
>From: Dan Aloni <[EMAIL PROTECTED]>
>
>Agreed. BTW, after grepping for IFNAMSIZ references I've noticed
>some architectures (sparc64, mips64) define IFNAMSIZ for
>themsleves, for ex
Date:Wed, 15 Nov 2000 02:25:38 +0200 (IST)
From: Dan Aloni <[EMAIL PROTECTED]>
Agreed. BTW, after grepping for IFNAMSIZ references I've noticed
some architectures (sparc64, mips64) define IFNAMSIZ for
themsleves, for example, arch/sparc64/kernel/ioctl32.c, which
defines
On Tue, 14 Nov 2000, Linus Torvalds wrote:
> On Wed, 15 Nov 2000, Dan Aloni wrote:
> >
> > summery: dev_3c501.name shouldn't be NULL, or we get oops
>
> Note that these days "name" is not a pointer at all, but an array, and as
> such cannot be NULL any more. Not initializing it will just cause i
In article <[EMAIL PROTECTED]>,
Dan Aloni <[EMAIL PROTECTED]> wrote:
>On Tue, 14 Nov 2000, Jeff Garzik wrote:
>
>> Dan Aloni wrote:
>> >
>> > reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
>> > net_init.c:register_netdev(&dev_3c501), which calls strchr(),
>> > {and might also,w
On Wed, 15 Nov 2000, Dan Aloni wrote:
>
> summery: dev_3c501.name shouldn't be NULL, or we get oops
Note that these days "name" is not a pointer at all, but an array, and as
such cannot be NULL any more. Not initializing it will just cause it to be
empty (ie is the same as initializing it to ""
Dan Aloni wrote:
>
> On Tue, 14 Nov 2000, Jeff Garzik wrote:
>
> > Dan Aloni wrote:
> > >
> > > reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
> > > net_init.c:register_netdev(&dev_3c501), which calls strchr(),
> > > {and might also,which might} dereference dev_3c501.name.
> >
On Tue, 14 Nov 2000, Jeff Garzik wrote:
> Dan Aloni wrote:
> >
> > reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
> > net_init.c:register_netdev(&dev_3c501), which calls strchr(),
> > {and might also,which might} dereference dev_3c501.name.
>
> There is no dereferencing involv
Dan Aloni wrote:
>
> against: test11-pre5
> summery: dev_3c501.name shouldn't be NULL, or we get oops
> reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
> net_init.c:register_netdev(&dev_3c501), which calls strchr(),
> {and might also,which might} dereference dev_3c501.name.
Ther
against: test11-pre5
summery: dev_3c501.name shouldn't be NULL, or we get oops
reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
net_init.c:register_netdev(&dev_3c501), which calls strchr(),
{and might also,which might} dereference dev_3c501.name.
--- linux/drivers/net/3c501.c W
11 matches
Mail list logo
