Re: [PATCH] Re: [test11-pre2] rrunner.c compiler error

2000-11-10 Thread Jeff Garzik
Blah. Puke. Ug. Not your changes, Bart... which are ok, but incomplete. Here is the complete bugfix. There are two places where error conditions are not fully handled, and 'out_spin' can kfree(image), saving some code. The worst bug of the list... if the firmware copy_from_user failed w

[PATCH] Re: [test11-pre2] rrunner.c compiler error

2000-11-10 Thread Bartlomiej Zolnierkiewicz
On Fri, 10 Nov 2000, Alan Cox wrote: > > rrunner.c : In function 'rr_ioctl' > > rrunner.c:1558: label 'out' used but not defined > > make[2]: *** [rrunner.o] Error 1 > > My fault. Swap that 1158 line pair > > error = -EPERM; > goto out; > > with > ret