Re: [PATCH] RDMA/ucma: Use struct_size() helper

2019-06-14 Thread Enrico Weigelt, metux IT consult
On 04.06.19 17:42, Gustavo A. R. Silva wrote: Hi, > diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c > index 140a338a135f..cbe460076611 100644 > --- a/drivers/infiniband/core/ucma.c > +++ b/drivers/infiniband/core/ucma.c > @@ -951,8 +951,7 @@ static ssize_t ucma_quer

Re: [PATCH] RDMA/ucma: Use struct_size() helper

2019-06-07 Thread Jason Gunthorpe
On Tue, Jun 04, 2019 at 10:42:22AM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > > si

Re: [PATCH] RDMA/ucma: Use struct_size() helper

2019-06-04 Thread Leon Romanovsky
On Tue, Jun 04, 2019 at 10:42:22AM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. What does "in particular in the context in

[PATCH] RDMA/ucma: Use struct_size() helper

2019-06-04 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace the following form: sizeof(*resp) + (i * sizeof(struct ib_path_rec_data)) with: struct_size(resp, path_