Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-03 Thread Alex Dewar
On Wed, Sep 02, 2020 at 07:34:26PM -0500, Gustavo A. R. Silva wrote: > Hi Alex, > > On 9/2/20 11:24, Alex Dewar wrote: > > In ucma_process_join(), if the call to xa_alloc() fails, the function > > will return without freeing mc. Fix this by jumping to the correct line. > > > > In the process I re

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Gustavo A. R. Silva
On 9/2/20 19:32, Jason Gunthorpe wrote: >>> Addresses-Coverity: ("Resource leak") >> >> If you are using a public Coverity scan, please also include the Coverity ID. >> In this case ID 1496814, something like: >> >> Addresses-Coverity-ID: 1496814 ("Resource leak") > > Thanks, I fixed it up >

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 07:34:26PM -0500, Gustavo A. R. Silva wrote: > Hi Alex, > > On 9/2/20 11:24, Alex Dewar wrote: > > In ucma_process_join(), if the call to xa_alloc() fails, the function > > will return without freeing mc. Fix this by jumping to the correct line. > > > > In the process I re

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Gustavo A. R. Silva
Hi Alex, On 9/2/20 11:24, Alex Dewar wrote: > In ucma_process_join(), if the call to xa_alloc() fails, the function > will return without freeing mc. Fix this by jumping to the correct line. > > In the process I renamed the jump labels to something more memorable for > extra clarity. > > Address

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 05:24:51PM +0100, Alex Dewar wrote: > In ucma_process_join(), if the call to xa_alloc() fails, the function > will return without freeing mc. Fix this by jumping to the correct line. > > In the process I renamed the jump labels to something more memorable for > extra clarit

[PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Alex Dewar
In ucma_process_join(), if the call to xa_alloc() fails, the function will return without freeing mc. Fix this by jumping to the correct line. In the process I renamed the jump labels to something more memorable for extra clarity. Addresses-Coverity: ("Resource leak") Fixes: 95fe51096b7a ("RDMA/u