Re: [PATCH] Put each per-cpu kdump ELF notes into a single page

2014-09-12 Thread Vivek Goyal
On Fri, Sep 12, 2014 at 12:15:37AM +0200, Petr Tesarik wrote: > On Thu, 11 Sep 2014 17:16:37 -0400 > Vivek Goyal wrote: > > > On Thu, Sep 11, 2014 at 10:43:30PM +0200, Petr Tesarik wrote: > > > On Thu, 11 Sep 2014 16:01:10 -0400 > > > Vivek Goyal wrote: > > > > > > > On Fri, Sep 05, 2014 at 06:

Re: [PATCH] Put each per-cpu kdump ELF notes into a single page

2014-09-11 Thread Petr Tesarik
On Thu, 11 Sep 2014 17:16:37 -0400 Vivek Goyal wrote: > On Thu, Sep 11, 2014 at 10:43:30PM +0200, Petr Tesarik wrote: > > On Thu, 11 Sep 2014 16:01:10 -0400 > > Vivek Goyal wrote: > > > > > On Fri, Sep 05, 2014 at 06:33:14PM +0200, Petr Tesarik wrote: > > > > On architectures that use percpu-vm

Re: [PATCH] Put each per-cpu kdump ELF notes into a single page

2014-09-11 Thread Vivek Goyal
On Thu, Sep 11, 2014 at 10:43:30PM +0200, Petr Tesarik wrote: > On Thu, 11 Sep 2014 16:01:10 -0400 > Vivek Goyal wrote: > > > On Fri, Sep 05, 2014 at 06:33:14PM +0200, Petr Tesarik wrote: > > > On architectures that use percpu-vm, the percpu region is not guaranteed > > > to be contiguous in phys

Re: [PATCH] Put each per-cpu kdump ELF notes into a single page

2014-09-11 Thread Petr Tesarik
On Thu, 11 Sep 2014 16:01:10 -0400 Vivek Goyal wrote: > On Fri, Sep 05, 2014 at 06:33:14PM +0200, Petr Tesarik wrote: > > On architectures that use percpu-vm, the percpu region is not guaranteed > > to be contiguous in physical space. > > Petr, > > Which are those arches? All except nommu. Act

Re: [PATCH] Put each per-cpu kdump ELF notes into a single page

2014-09-11 Thread Vivek Goyal
On Fri, Sep 05, 2014 at 06:33:14PM +0200, Petr Tesarik wrote: > On architectures that use percpu-vm, the percpu region is not guaranteed > to be contiguous in physical space. Petr, Which are those arches? > However, fs/proc/vmcore.c expects > all ELF notes to be contiguous. If the ELF note happe

Re: [PATCH] Put each per-cpu kdump ELF notes into a single page

2014-09-11 Thread Petr Tesarik
Hi all, is anything wrong with the patch below? Are there questions? I thought this would be an easy one-line bugfix... Regards, Petr Tesarik On Fri, 5 Sep 2014 18:33:14 +0200 Petr Tesarik wrote: > On architectures that use percpu-vm, the percpu region is not guaranteed > to be contiguous in p

[PATCH] Put each per-cpu kdump ELF notes into a single page

2014-09-05 Thread Petr Tesarik
On architectures that use percpu-vm, the percpu region is not guaranteed to be contiguous in physical space. However, fs/proc/vmcore.c expects all ELF notes to be contiguous. If the ELF note happens to occupy two non-adjacent physical pages, part of the note may be read from an incorrect memory loc