Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-25 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. This version implements a correction to jiffies_64_to_usecs() based on feedback from Randy D

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Randy Dunlap
Jonathan Lim wrote: It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. This version implements a correction to jiffies_64_to_usecs() based on

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. This version implements a correction to jiffies_64_to_usecs() based on feedback from Randy D

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in

2008-02-19 Thread Randy Dunlap
On Tue, 19 Feb 2008 13:59:27 -0800 (PST) Jonathan Lim wrote: > On Tue Feb 19 13:25:25 2008, [EMAIL PROTECTED] wrote: > > > > > +u64 inline jiffies_64_to_usecs(const u64 j) > > > +{ > > > + u64 tmp = j*HZ_TO_USEC_NUM + HZ_TO_USEC_DEN-1; > > > + do_div(tmp, HZ_TO_USEC_DEN); > > > > do_div() is: >

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in

2008-02-19 Thread Jonathan Lim
On Tue Feb 19 13:25:25 2008, [EMAIL PROTECTED] wrote: > > > +u64 inline jiffies_64_to_usecs(const u64 j) > > +{ > > + u64 tmp = j*HZ_TO_USEC_NUM + HZ_TO_USEC_DEN-1; > > + do_div(tmp, HZ_TO_USEC_DEN); > > do_div() is: > * The semantics of do_div() are: > * > * uint32_t do_div(uint64_t *n, u

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Randy Dunlap
On Tue, 19 Feb 2008 12:52:46 -0800 (PST) Jonathan Lim wrote: > It's possible that the values used in and returned from jiffies_to_usecs() are > incorrect because of truncation when variables of type u64 are involved. So a > function specific to that type is used instead. > > Diff'd against: linu

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Diff'd against: linux/kernel/git/torvalds/linux-2.6.git Signed-off-by: Jonathan Lim <[EMAIL

[PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-14 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Diff'd against: linux/kernel/git/torvalds/linux-2.6.git Signed-off-by: Jonathan Lim <[EMAIL

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-07 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Updated from previous submission with feedback from Peter Anvin. Diff'd against: linux/kern

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread H. Peter Anvin
Jonathan Lim wrote: Peter, Would you be willing to include the u64 function as part of your patch to make it available kernel-wide? It just needs: u64 inline jiffies_to_usecs_u64(const u64 j) and for the symbol to be exported. Thanks. It should be a separate patch (new functionality ve

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread Jonathan Lim
On Wed Jan 2 16:36:47 2008, [EMAIL PROTECTED] wrote: > > Andrew Morton wrote: > > On Fri, 28 Dec 2007 13:26:07 -0800 (PST) Jonathan Lim <[EMAIL PROTECTED]> > > wrote: > > > >> It's possible that the values used in and returned from jiffies_to_usecs() > >> are incorrect because of truncation whe

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread H. Peter Anvin
Andrew Morton wrote: On Fri, 28 Dec 2007 13:26:07 -0800 (PST) Jonathan Lim <[EMAIL PROTECTED]> wrote: It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is u

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread Andrew Morton
On Fri, 28 Dec 2007 13:26:07 -0800 (PST) Jonathan Lim <[EMAIL PROTECTED]> wrote: > It's possible that the values used in and returned from jiffies_to_usecs() are > incorrect because of truncation when variables of type u64 are involved. So a > function specific to that type is used instead. > >

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2007-12-28 Thread H. Peter Anvin
Jonathan Lim wrote: It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Much worse than that. There are internal overflows in the conversion

[PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2007-12-28 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Diff'd against: linux/kernel/git/stable/linux-2.6.23.y.git Signed-off-by: Jonathan Lim <[EM