Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-11-05 Thread Viresh Kumar
On 02-11-15, 11:14, Stephen Boyd wrote: > On 10/31, Viresh Kumar wrote: > > I don't know what is wrong (or right) with my exynos 5250 board, but I > > didn't got any splat here even with the right config options (yes I > > should have mentioned that earlier). I have seen this at other times > > as

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-11-04 Thread Stephen Boyd
On 10/30, Viresh Kumar wrote: > dev_opp_list_lock is used everywhere to protect device and OPP lists, > but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used > rcu-lock, which wouldn't help here as we are adding a new list_dev. > > This also fixes a problem where we have called

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-11-04 Thread Viresh Kumar
On 04-11-15, 02:22, Michael Turquette wrote: > Splat: > Thanks, but I also need your Tested-by :) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-11-04 Thread Michael Turquette
Quoting Viresh Kumar (2015-10-30 19:14:09) > On 30-10-15, 10:06, Stephen Boyd wrote: > > On 10/30, Viresh Kumar wrote: > > > dev_opp_list_lock is used everywhere to protect device and OPP lists, > > > but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used > > > rcu-lock, which wou

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-11-03 Thread Viresh Kumar
On 02-11-15, 11:14, Stephen Boyd wrote: > On 10/31, Viresh Kumar wrote: > > On 30-10-15, 10:06, Stephen Boyd wrote: > > > On 10/30, Viresh Kumar wrote: > > > > dev_opp_list_lock is used everywhere to protect device and OPP lists, > > > > but dev_pm_opp_set_sharing_cpus() is missed somehow. And inst

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-11-02 Thread Stephen Boyd
On 10/31, Viresh Kumar wrote: > On 30-10-15, 10:06, Stephen Boyd wrote: > > On 10/30, Viresh Kumar wrote: > > > dev_opp_list_lock is used everywhere to protect device and OPP lists, > > > but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used > > > rcu-lock, which wouldn't help he

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-10-30 Thread Viresh Kumar
On 30-10-15, 10:06, Stephen Boyd wrote: > On 10/30, Viresh Kumar wrote: > > dev_opp_list_lock is used everywhere to protect device and OPP lists, > > but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used > > rcu-lock, which wouldn't help here as we are adding a new list_dev. > >

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-10-30 Thread Stephen Boyd
On 10/30, Viresh Kumar wrote: > dev_opp_list_lock is used everywhere to protect device and OPP lists, > but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used > rcu-lock, which wouldn't help here as we are adding a new list_dev. > > This also fixes a problem where we have called

Re: [PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-10-30 Thread Dan Carpenter
On Fri, Oct 30, 2015 at 05:26:06PM +0530, Viresh Kumar wrote: > --- a/drivers/base/power/opp/cpu.c > +++ b/drivers/base/power/opp/cpu.c > @@ -124,12 +124,12 @@ int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, > cpumask_var_t cpumask) > struct device *dev; > int cpu, ret = 0; >

[PATCH] PM / OPP: Protect updates to list_dev with mutex

2015-10-30 Thread Viresh Kumar
dev_opp_list_lock is used everywhere to protect device and OPP lists, but dev_pm_opp_set_sharing_cpus() is missed somehow. And instead we used rcu-lock, which wouldn't help here as we are adding a new list_dev. This also fixes a problem where we have called kzalloc(..., GFP_KERNEL) from within rcu