Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set()

2016-02-03 Thread Ulf Hansson
On 3 February 2016 at 13:08, Rafael J. Wysocki wrote: > On Wed, Feb 3, 2016 at 10:58 AM, Ulf Hansson wrote: >> On 30 January 2016 at 12:54, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts >>> to set the pm_domain

Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set()

2016-02-03 Thread Rafael J. Wysocki
On Wed, Feb 3, 2016 at 10:58 AM, Ulf Hansson wrote: > On 30 January 2016 at 12:54, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts >> to set the pm_domain pointer for devices with a driver bound. >> >> However, that

Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set()

2016-02-03 Thread Ulf Hansson
On 30 January 2016 at 12:54, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts > to set the pm_domain pointer for devices with a driver bound. > > However, that WARN_ON() triggers on attempts to clear the pointer > too and

Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set()

2016-02-01 Thread Andy Shevchenko
On Sat, 2016-01-30 at 12:54 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts > to set the pm_domain pointer for devices with a driver bound. > > However, that WARN_ON() triggers on attempts to clear the pointer >

[PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set()

2016-01-30 Thread Rafael J. Wysocki
From: Rafael J. Wysocki There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts to set the pm_domain pointer for devices with a driver bound. However, that WARN_ON() triggers on attempts to clear the pointer too and the test it uses is based on checking the device's p->knode_driver