Re: [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency

2005-02-07 Thread John Rose
> Er, use the result of the get_children_props() call only if it _failed_? > I suspect that wasn't your intention. This makes my G5 boot again: Here's an alternate fix for the ppc64 crash during boot. This corrects the offending function to use more conventional error codes. I'll follow up with

Re: [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency

2005-02-07 Thread David Woodhouse
On Mon, 2005-02-07 at 11:41 -0600, John Rose wrote: > BTW, you're running an RPA module on your G5? Fedora uses the same ppc64 kernel for both pSeries and G5. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency

2005-02-07 Thread Andrew Morton
John Rose <[EMAIL PROTECTED]> wrote: > > Could we please get David's fix in for 2.6.11, since it's apparently > affecting boot in some situations? Yup, I can take care of that. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency

2005-02-07 Thread John Rose
Could we please get David's fix in for 2.6.11, since it's apparently affecting boot in some situations? Thanks- John On Mon, 2005-02-07 at 11:41, John Rose wrote: > > Er, use the result of the get_children_props() call only if it _failed_? > > I suspect that wasn't your intention. This makes my G

Re: [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency

2005-02-07 Thread John Rose
> Er, use the result of the get_children_props() call only if it _failed_? > I suspect that wasn't your intention. This makes my G5 boot again: Doh, good catch! This was an oversight while patching multiple trees for this bug. Previous versions of that function use 1 for success. Sigh. BTW, yo

Re: [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency

2005-02-07 Thread David Woodhouse
On Thu, 2005-02-03 at 08:41 +, Linux Kernel Mailing List wrote: > [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency > > The RPA PCI Hotplug module incorrectly uses a certain firmware > property when > determining the hotplug ca

[PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency

2005-02-03 Thread Greg KH
ChangeSet 1.2044, 2005/02/03 00:41:04-08:00, [EMAIL PROTECTED] [PATCH] PCI Hotplug: remove incorrect rpaphp firmware dependency The RPA PCI Hotplug module incorrectly uses a certain firmware property when determining the hotplug capabilities of a slot. Recent firmware changes have demonstrated