Re: [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map

2014-12-09 Thread Bjorn Helgaas
On Fri, Nov 14, 2014 at 02:21:53PM -0800, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov Applied with Phil's ack to next-pci/host-rcar for v3.19. This br

RE: [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map

2014-11-18 Thread Phil Edworthy
Hi Dmitry, On 14 November 2014 22:22, Dmitry wrote: > > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov Acked-by: Phil Edworthy Thanks Phil > --- > > Not tested, found by cas

[PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual code inspection. drivers/pci/host/pcie-rcar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)