Re: [PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-07 Thread Bjorn Helgaas
Hi Prarit, On Tue, Oct 06, 2015 at 04:02:22PM -0400, Prarit Bhargava wrote: > On 10/06/2015 03:36 PM, Bjorn Helgaas wrote: > > On Sun, Oct 04, 2015 at 05:49:29PM -0400, Sasha Levin wrote: > >> Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check > >> that > >> the numa node pr

Re: [PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-07 Thread Bjorn Helgaas
On Wed, Oct 07, 2015 at 10:07:33AM -0400, Sasha Levin wrote: > > On 10/06/2015 03:36 PM, Bjorn Helgaas wrote: > >> Hi Sasha, > >> > >> On Sun, Oct 04, 2015 at 05:49:29PM -0400, Sasha Levin wrote: > >>> Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check > >>> that > >>> the nu

Re: [PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-07 Thread Sasha Levin
On 10/06/2015 04:02 PM, Prarit Bhargava wrote: > > > On 10/06/2015 03:36 PM, Bjorn Helgaas wrote: >> Hi Sasha, >> >> On Sun, Oct 04, 2015 at 05:49:29PM -0400, Sasha Levin wrote: >>> Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check >>> that >>> the numa node provided by us

Re: [PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-06 Thread Prarit Bhargava
On 10/06/2015 03:36 PM, Bjorn Helgaas wrote: > Hi Sasha, > > On Sun, Oct 04, 2015 at 05:49:29PM -0400, Sasha Levin wrote: >> Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check that >> the numa node provided by userspace is valid. Passing a node number too high >> would atte

Re: [PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-06 Thread Bjorn Helgaas
Hi Sasha, On Sun, Oct 04, 2015 at 05:49:29PM -0400, Sasha Levin wrote: > Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check that > the numa node provided by userspace is valid. Passing a node number too high > would attempt to access invalid memory and trigger a kernel panic.

[PATCH] PCI: prevent out of bounds access in numa_node override

2015-10-04 Thread Sasha Levin
Commit 63692df1 ("PCI: Allow numa_node override via sysfs") didn't check that the numa node provided by userspace is valid. Passing a node number too high would attempt to access invalid memory and trigger a kernel panic. Fixes: 63692df1 ("PCI: Allow numa_node override via sysfs") Signed-off-by: S