Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On 03.08.2018 21:40, Thomas Gleixner wrote: > On Fri, 3 Aug 2018, Heiner Kallweit wrote: >> On 03.08.2018 16:09, Thomas Gleixner wrote: >>> On Wed, 1 Aug 2018, Heiner Kallweit wrote: diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c index 4ca2fd46..ba6da943 100644 --- a/kernel/irq/msi

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Fri, 3 Aug 2018, Heiner Kallweit wrote: > On 03.08.2018 16:09, Thomas Gleixner wrote: > > On Wed, 1 Aug 2018, Heiner Kallweit wrote: > >> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c > >> index 4ca2fd46..ba6da943 100644 > >> --- a/kernel/irq/msi.c > >> +++ b/kernel/irq/msi.c > >> @@ -289,6 +

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On 03.08.2018 16:09, Thomas Gleixner wrote: > On Wed, 1 Aug 2018, Heiner Kallweit wrote: >> On 31.07.2018 08:15, Marc Zyngier wrote: >>> On Mon, 30 Jul 2018 23:36:57 +0100, >>> Thomas Gleixner wrote: Yes, request for pure threaded interrupts are rejected if the oneshot flag is not s

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Wed, 1 Aug 2018, Heiner Kallweit wrote: > On 31.07.2018 08:15, Marc Zyngier wrote: > > On Mon, 30 Jul 2018 23:36:57 +0100, > > Thomas Gleixner wrote: > >> > >> Yes, request for pure threaded interrupts are rejected if the oneshot flag > >> is not set. The reason is that this would be deadly esp

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On 31.07.2018 08:15, Marc Zyngier wrote: > On Mon, 30 Jul 2018 23:36:57 +0100, > Thomas Gleixner wrote: >> >> On Mon, 30 Jul 2018, Bjorn Helgaas wrote: >> >>> [+cc Thomas, Christoph, LKML] >> >> + Marc >> >>> On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: If we have a thread

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Tue, Jul 31, 2018 at 09:01:12AM +0100, Russell King - ARM Linux wrote: > On Tue, Jul 31, 2018 at 12:50:21AM +0200, Thomas Gleixner wrote: > > On Mon, 30 Jul 2018, Bjorn Helgaas wrote: > > > > > [+cc maintainers of possibly erroneous callers of request_threaded_irq()] > > > > > > On Mon, Jul 30

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On 31 July 2018 at 00:42, Bjorn Helgaas wrote: > [+cc maintainers of possibly erroneous callers of request_threaded_irq()] > > On Mon, Jul 30, 2018 at 04:30:28PM -0500, Bjorn Helgaas wrote: >> [+cc Thomas, Christoph, LKML] >> >> On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: >> >

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Tue, Jul 31, 2018 at 12:50:21AM +0200, Thomas Gleixner wrote: > On Mon, 30 Jul 2018, Bjorn Helgaas wrote: > > > [+cc maintainers of possibly erroneous callers of request_threaded_irq()] > > > > On Mon, Jul 30, 2018 at 04:30:28PM -0500, Bjorn Helgaas wrote: > > > [+cc Thomas, Christoph, LKML] >

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Tue, 31 Jul 2018, Thomas Gleixner wrote: > On Mon, 30 Jul 2018, Bjorn Helgaas wrote: > > > [+cc maintainers of possibly erroneous callers of request_threaded_irq()] > > > > On Mon, Jul 30, 2018 at 04:30:28PM -0500, Bjorn Helgaas wrote: > > > [+cc Thomas, Christoph, LKML] > > > > > > On Mon,

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Mon, 30 Jul 2018 23:36:57 +0100, Thomas Gleixner wrote: > > On Mon, 30 Jul 2018, Bjorn Helgaas wrote: > > > [+cc Thomas, Christoph, LKML] > > + Marc > > > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: > > > If we have a threaded interrupt with the handler being NULL, then

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Mon, 30 Jul 2018, Bjorn Helgaas wrote: > [+cc maintainers of possibly erroneous callers of request_threaded_irq()] > > On Mon, Jul 30, 2018 at 04:30:28PM -0500, Bjorn Helgaas wrote: > > [+cc Thomas, Christoph, LKML] > > > > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: > >

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

[+cc maintainers of possibly erroneous callers of request_threaded_irq()] On Mon, Jul 30, 2018 at 04:30:28PM -0500, Bjorn Helgaas wrote: > [+cc Thomas, Christoph, LKML] > > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: > > If we have a threaded interrupt with the handler being

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Mon, 30 Jul 2018, Bjorn Helgaas wrote: > [+cc Thomas, Christoph, LKML] + Marc > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: > > If we have a threaded interrupt with the handler being NULL, then > > request_threaded_irq() -> __setup_irq() will complain and bail out > > if

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On Tue, Jul 31, 2018 at 12:30 AM, Bjorn Helgaas wrote: > [+cc Thomas, Christoph, LKML] > > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: >> If we have a threaded interrupt with the handler being NULL, then >> request_threaded_irq() -> __setup_irq() will complain and bail out >>

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

On 30.07.2018 23:30, Bjorn Helgaas wrote: > [+cc Thomas, Christoph, LKML] > > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: >> If we have a threaded interrupt with the handler being NULL, then >> request_threaded_irq() -> __setup_irq() will complain and bail out >> if the IRQF_O

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

[+cc Thomas, Christoph, LKML] On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: > If we have a threaded interrupt with the handler being NULL, then > request_threaded_irq() -> __setup_irq() will complain and bail out > if the IRQF_ONESHOT flag isn't set. Therefore check for the hand