Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-11-05 Thread Bjorn Helgaas
On Mon, Nov 04, 2013 at 01:44:08PM +0100, Paul Bolle wrote: > On Fri, 2013-10-04 at 09:55 -0600, Bjorn Helgaas wrote: > > On Thu, Oct 3, 2013 at 5:35 PM, Yinghai Lu wrote: > > > On Thu, Oct 3, 2013 at 3:06 PM, Bjorn Helgaas wrote: > > >> On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote:

Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-11-04 Thread Paul Bolle
On Fri, 2013-10-04 at 09:55 -0600, Bjorn Helgaas wrote: > On Thu, Oct 3, 2013 at 5:35 PM, Yinghai Lu wrote: > > On Thu, Oct 3, 2013 at 3:06 PM, Bjorn Helgaas wrote: > >> On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: > >>> @@ -1156,8 +1156,14 @@ static void pci_enable_bridge(struct p

Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-10-04 Thread Bjorn Helgaas
On Thu, Oct 3, 2013 at 5:35 PM, Yinghai Lu wrote: > On Thu, Oct 3, 2013 at 3:06 PM, Bjorn Helgaas wrote: >> On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: >>> @@ -1156,8 +1156,14 @@ static void pci_enable_bridge(struct pci >>> >>> pci_enable_bridge(dev->bus->self); >>> >>> -

Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-10-03 Thread Yinghai Lu
On Thu, Oct 3, 2013 at 3:06 PM, Bjorn Helgaas wrote: > On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: >> @@ -1156,8 +1156,14 @@ static void pci_enable_bridge(struct pci >> >> pci_enable_bridge(dev->bus->self); >> >> - if (pci_is_enabled(dev)) >> + if (pci_is_enabled(dev)

Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-10-03 Thread Bjorn Helgaas
On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: > BenH found: > | 928bea964827d7824b548c1f8e06eccbbc4d0d7d > | PCI: Delay enabling bridges until they're needed > > break PCI on powerpc. The reason is that the PCIe port driver will > call pci_enable_device() on the bridge, so device en

Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-09-29 Thread Theodore Ts'o
On Sun, Sep 29, 2013 at 03:46:33PM -0700, Linus Torvalds wrote: > On Sun, Sep 29, 2013 at 3:41 PM, Theodore Ts'o wrote: > > On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: > >> Fixed by add checking in pci_enable_bridge, and call pci_set_master > >> if driver skip that. > >> That will

Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-09-29 Thread Linus Torvalds
On Sun, Sep 29, 2013 at 3:41 PM, Theodore Ts'o wrote: > On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: >> Fixed by add checking in pci_enable_bridge, and call pci_set_master >> if driver skip that. >> That will make the code more robot and wade off problem for missing >> pci_set_maste

Re: [PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-09-29 Thread Theodore Ts'o
On Sat, Sep 28, 2013 at 01:13:07PM -0700, Yinghai Lu wrote: > Fixed by add checking in pci_enable_bridge, and call pci_set_master > if driver skip that. > That will make the code more robot and wade off problem for missing > pci_set_master in drivers. Petty spelling nit; feel free to ignore unless

[PATCH] PCI: Workaround missing pci_set_master in pci drivers

2013-09-28 Thread Yinghai Lu
BenH found: | 928bea964827d7824b548c1f8e06eccbbc4d0d7d | PCI: Delay enabling bridges until they're needed break PCI on powerpc. The reason is that the PCIe port driver will call pci_enable_device() on the bridge, so device enabled (but skip pci_set_master because pcie_port_auto and no acpi on pow