Re: [PATCH] PCI: PCIe: PME: Fix pcie_pme_remove()

2019-02-28 Thread Bjorn Helgaas
On Wed, Feb 27, 2019 at 5:58 PM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > It is incorrect to call pcie_pme_suspend() from pcie_pme_remove() for > two reasons. > > First, pcie_pme_suspend() calls synchronize_irq() that will wait for > the native hotplug interrupt handler as well as

[PATCH] PCI: PCIe: PME: Fix pcie_pme_remove()

2019-02-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki It is incorrect to call pcie_pme_suspend() from pcie_pme_remove() for two reasons. First, pcie_pme_suspend() calls synchronize_irq() that will wait for the native hotplug interrupt handler as well as for the PME one, because they share one IRQ (as per the spec). That may