Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-09 Thread Don Dutile
On 10/09/2019 08:31 AM, Bjorn Helgaas wrote: On Tue, Oct 08, 2019 at 06:06:46PM -0400, Don Dutile wrote: On 10/08/2019 05:38 PM, Bjorn Helgaas wrote: On Thu, Oct 03, 2019 at 05:10:07PM -0500, Bjorn Helgaas wrote: On Thu, Oct 03, 2019 at 11:04:45AM +0200, CREGUT Pierre IMT/OLN wrote: ... NI

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-09 Thread Bjorn Helgaas
On Tue, Oct 08, 2019 at 06:06:46PM -0400, Don Dutile wrote: > On 10/08/2019 05:38 PM, Bjorn Helgaas wrote: > > On Thu, Oct 03, 2019 at 05:10:07PM -0500, Bjorn Helgaas wrote: > > > On Thu, Oct 03, 2019 at 11:04:45AM +0200, CREGUT Pierre IMT/OLN wrote: > > > > ... > > > > > > NIC drivers send netlin

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-08 Thread Don Dutile
On 10/08/2019 05:38 PM, Bjorn Helgaas wrote: On Thu, Oct 03, 2019 at 05:10:07PM -0500, Bjorn Helgaas wrote: On Thu, Oct 03, 2019 at 11:04:45AM +0200, CREGUT Pierre IMT/OLN wrote: ... NIC drivers send netlink events when their state change, but it is the core that changes the value of num_vfs

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-08 Thread Bjorn Helgaas
On Thu, Oct 03, 2019 at 05:10:07PM -0500, Bjorn Helgaas wrote: > On Thu, Oct 03, 2019 at 11:04:45AM +0200, CREGUT Pierre IMT/OLN wrote: > > ... > > NIC drivers send netlink events when their state change, but it is > > the core that changes the value of num_vfs. So I would think it is > > the core

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-03 Thread Duyck, Alexander H
On Thu, 2019-10-03 at 17:10 -0500, Bjorn Helgaas wrote: > [+cc Don, Alex, Jakub] > > On Thu, Oct 03, 2019 at 11:04:45AM +0200, CREGUT Pierre IMT/OLN wrote: > > Le 02/10/2019 à 01:45, Bjorn Helgaas a écrit : > > > On Fri, Apr 26, 2019 at 10:11:54AM +0200, CREGUT Pierre IMT/OLN wrote: > > > > I also

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-03 Thread Jakub Kicinski
On Thu, 3 Oct 2019 17:10:07 -0500, Bjorn Helgaas wrote: > On Thu, Oct 03, 2019 at 11:04:45AM +0200, CREGUT Pierre IMT/OLN wrote: > > Le 02/10/2019 à 01:45, Bjorn Helgaas a écrit : > > > On Fri, Apr 26, 2019 at 10:11:54AM +0200, CREGUT Pierre IMT/OLN wrote: > > > > I also initially thought that

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-03 Thread Bjorn Helgaas
[+cc Don, Alex, Jakub] On Thu, Oct 03, 2019 at 11:04:45AM +0200, CREGUT Pierre IMT/OLN wrote: > Le 02/10/2019 à 01:45, Bjorn Helgaas a écrit : > > On Fri, Apr 26, 2019 at 10:11:54AM +0200, CREGUT Pierre IMT/OLN wrote: > > > I also initially thought that kobject_uevent generated the netlink event >

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-03 Thread CREGUT Pierre IMT/OLN
Le 02/10/2019 à 01:45, Bjorn Helgaas a écrit : On Fri, Apr 26, 2019 at 10:11:54AM +0200, CREGUT Pierre IMT/OLN wrote: I also initially thought that kobject_uevent generated the netlink event but this is not the case. This is generated by the specific driver in use. For the Intel i40e driver, thi

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-10-01 Thread Bjorn Helgaas
On Fri, Apr 26, 2019 at 10:11:54AM +0200, CREGUT Pierre IMT/OLN wrote: > I also initially thought that kobject_uevent generated the netlink event > but this is not the case. This is generated by the specific driver in use. > For the Intel i40e driver, this is the call to i40e_do_reset_safe in > i40

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-06-13 Thread Bjorn Helgaas
Hi Pierre, I'm really sorry, I totally missed your response. On Fri, Apr 26, 2019 at 10:11:54AM +0200, CREGUT Pierre IMT/OLN wrote: > I also initially thought that kobject_uevent generated the netlink event > but this is not the case. This is generated by the specific driver in use. > For the Int

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-04-26 Thread CREGUT Pierre IMT/OLN
I also initially thought that kobject_uevent generated the netlink event but this is not the case. This is generated by the specific driver in use. For the Intel i40e driver, this is the call to i40e_do_reset_safe in i40e_pci_sriov_configure that sends the event. It is followed by i40e_pci_sriov_e

Re: [PATCH] PCI/IOV: update num_VFs earlier

2019-04-05 Thread Bjorn Helgaas
On Fri, Mar 29, 2019 at 09:00:58AM +0100, Pierre Crégut wrote: > Ensure that iov->num_VFs is set before a netlink message is sent > when the number of VFs is changed. Only the path for num_VFs > 0 > is affected. The path for num_VFs = 0 is already correct. > > Monitoring programs can relie on netl

[PATCH] PCI/IOV: update num_VFs earlier

2019-03-29 Thread Pierre Crégut
Ensure that iov->num_VFs is set before a netlink message is sent when the number of VFs is changed. Only the path for num_VFs > 0 is affected. The path for num_VFs = 0 is already correct. Monitoring programs can relie on netlink messages to track interface change and query their state in /sys. But