Re: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear.

2018-01-11 Thread Rafael J. Wysocki
On Thu, Jan 11, 2018 at 8:04 PM, Borislav Petkov wrote: > On Thu, Jan 11, 2018 at 07:03:23PM +0100, Rafael J. Wysocki wrote: >> >> > + if (!(requested & control & OSC_PCI_EXPRESS_AER_CONTROL)) >> >> >> >> One of the operators above needs to be a && I suppose? >> >> >> > >> > It's a 3-way bit

Re: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear.

2018-01-11 Thread Borislav Petkov
On Thu, Jan 11, 2018 at 07:03:23PM +0100, Rafael J. Wysocki wrote: > >> > + if (!(requested & control & OSC_PCI_EXPRESS_AER_CONTROL)) > >> > >> One of the operators above needs to be a && I suppose? > >> > > > > It's a 3-way bitwise AND to check that OSC_PCI_EXPRESS_AER_CONTROL is > > set in

Re: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear.

2018-01-11 Thread Bjorn Helgaas
On Thu, Jan 11, 2018 at 09:03:16AM -0600, Yazen Ghannam wrote: > From: Yazen Ghannam > > Currently, aer_service_init() checks if AER is available and that > Firmware First handling is not enabled. The _OSC request for AER is > not taken into account when deciding to enable AER in Linux. > > We s

Re: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear.

2018-01-11 Thread Rafael J. Wysocki
l Maling List ; Linux Kernel Mailing >> List ; Linux PCI ; >> Rafael J. Wysocki ; Len Brown ; Bjorn >> Helgaas ; Borislav Petkov >> Subject: Re: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear. >> >> On Thu, Jan 11, 2018 at 4:03 PM, Yazen Ghannam &g

RE: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear.

2018-01-11 Thread Ghannam, Yazen
ocki ; Len Brown ; Bjorn > Helgaas ; Borislav Petkov > Subject: Re: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear. > > On Thu, Jan 11, 2018 at 4:03 PM, Yazen Ghannam > wrote: > > From: Yazen Ghannam > > > > Currently, aer_service_init() checks if

Re: [PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear.

2018-01-11 Thread Rafael J. Wysocki
On Thu, Jan 11, 2018 at 4:03 PM, Yazen Ghannam wrote: > From: Yazen Ghannam > > Currently, aer_service_init() checks if AER is available and that > Firmware First handling is not enabled. The _OSC request for AER is > not taken into account when deciding to enable AER in Linux. > > We should chec

[PATCH] PCI/ACPI: Disable AER when _OSC control bit is clear.

2018-01-11 Thread Yazen Ghannam
From: Yazen Ghannam Currently, aer_service_init() checks if AER is available and that Firmware First handling is not enabled. The _OSC request for AER is not taken into account when deciding to enable AER in Linux. We should check that the _OSC control for AER is set. If it's not then AER should