Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-29 Thread boris . ostrovsky
+Lennart On 9/29/20 9:36 AM, Philipp Rudo wrote: > Hi, > > On Fri, 25 Sep 2020 10:56:25 -0400 > Konrad Rzeszutek Wilk wrote: > >> On Fri, Sep 25, 2020 at 11:05:58AM +0800, Dave Young wrote: >>> Hi, >>> >>> On 09/24/20 at 01:16pm, boris.ostrov...@oracle.com wrote: On 9/24/20 12:43 PM, Mich

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-29 Thread Philipp Rudo
Hi, On Fri, 25 Sep 2020 10:56:25 -0400 Konrad Rzeszutek Wilk wrote: > On Fri, Sep 25, 2020 at 11:05:58AM +0800, Dave Young wrote: > > Hi, > > > > On 09/24/20 at 01:16pm, boris.ostrov...@oracle.com wrote: > > > > > > On 9/24/20 12:43 PM, Michael Kelley wrote: > > > > From: Eric W. Biederman

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-26 Thread Dave Young
Hi, On 09/25/20 at 10:56am, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 25, 2020 at 11:05:58AM +0800, Dave Young wrote: > > Hi, > > > > On 09/24/20 at 01:16pm, boris.ostrov...@oracle.com wrote: > > > > > > On 9/24/20 12:43 PM, Michael Kelley wrote: > > > > From: Eric W. Biederman Sent: Thursday,

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-25 Thread Konrad Rzeszutek Wilk
On Fri, Sep 25, 2020 at 11:05:58AM +0800, Dave Young wrote: > Hi, > > On 09/24/20 at 01:16pm, boris.ostrov...@oracle.com wrote: > > > > On 9/24/20 12:43 PM, Michael Kelley wrote: > > > From: Eric W. Biederman Sent: Thursday, September > > > 24, 2020 9:26 AM > > >> Michael Kelley writes: > > >>

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-24 Thread Dave Young
Hi, On 09/24/20 at 01:16pm, boris.ostrov...@oracle.com wrote: > > On 9/24/20 12:43 PM, Michael Kelley wrote: > > From: Eric W. Biederman Sent: Thursday, September > > 24, 2020 9:26 AM > >> Michael Kelley writes: > >> > > Added Hyper-V people and people who created the param, it is below >

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-24 Thread boris . ostrovsky
On 9/24/20 12:43 PM, Michael Kelley wrote: > From: Eric W. Biederman Sent: Thursday, September 24, > 2020 9:26 AM >> Michael Kelley writes: >> > Added Hyper-V people and people who created the param, it is below > commit, I also want to remove it if possible, let's see how people >

RE: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-24 Thread Michael Kelley
From: Eric W. Biederman Sent: Thursday, September 24, 2020 9:26 AM > > Michael Kelley writes: > > >> > > >> > Added Hyper-V people and people who created the param, it is below > >> > commit, I also want to remove it if possible, let's see how people > >> > think, but the least way should be t

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-24 Thread Eric W. Biederman
Michael Kelley writes: > From: Konrad Rzeszutek Wilk Sent: Wednesday, > September 23, 2020 8:48 AM >> >> On Wed, Sep 23, 2020 at 10:43:29AM +0800, Dave Young wrote: >> > + more people who may care about this param >> >> Paarty time!! >> >> (See below, didn't snip any comments) >> > On 09/21/

RE: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-24 Thread Michael Kelley
From: Konrad Rzeszutek Wilk Sent: Wednesday, September 23, 2020 8:48 AM > > On Wed, Sep 23, 2020 at 10:43:29AM +0800, Dave Young wrote: > > + more people who may care about this param > > Paarty time!! > > (See below, didn't snip any comments) > > On 09/21/20 at 08:45pm, Eric W. Biederman wrot

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-23 Thread Konrad Rzeszutek Wilk
On Wed, Sep 23, 2020 at 10:43:29AM +0800, Dave Young wrote: > + more people who may care about this param Paarty time!! (See below, didn't snip any comments) > On 09/21/20 at 08:45pm, Eric W. Biederman wrote: > > Konrad Rzeszutek Wilk writes: > > > > > On Fri, Sep 18, 2020 at 05:47:43PM -0700,

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-22 Thread Dave Young
+ more people who may care about this param On 09/21/20 at 08:45pm, Eric W. Biederman wrote: > Konrad Rzeszutek Wilk writes: > > > On Fri, Sep 18, 2020 at 05:47:43PM -0700, Andrew Morton wrote: > >> On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > >> > >> > crash_kexec_post_notifiers ena

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-22 Thread Dave Young
On 09/21/20 at 04:18pm, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 18, 2020 at 05:47:43PM -0700, Andrew Morton wrote: > > On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > > > > > crash_kexec_post_notifiers enables running various panic notifier > > > before kdump kernel booting. This increa

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-22 Thread Guilherme G. Piccoli
On Tue, Sep 22, 2020 at 11:53 AM wrote: > > > On 9/22/20 6:58 AM, Philipp Rudo wrote: > > > > AFAIK pstore requires UEFI to work. So what's the point to enable it on > > non-UEFI > > systems? > > > I don't think UEFI is required, ERST can specify its own backend. And that, > in fact, can be quit

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-22 Thread boris . ostrovsky
On 9/22/20 6:58 AM, Philipp Rudo wrote: > > AFAIK pstore requires UEFI to work. So what's the point to enable it on > non-UEFI > systems? I don't think UEFI is required, ERST can specify its own backend. And that, in fact, can be quite useful in virtualization scenarios (especially in cases o

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-22 Thread Philipp Rudo
Hi Konrad, On Mon, 21 Sep 2020 16:18:12 -0400 Konrad Rzeszutek Wilk wrote: > On Fri, Sep 18, 2020 at 05:47:43PM -0700, Andrew Morton wrote: > > On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > > > > > crash_kexec_post_notifiers enables running various panic notifier > > > before kdump

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-21 Thread Eric W. Biederman
Konrad Rzeszutek Wilk writes: > On Fri, Sep 18, 2020 at 05:47:43PM -0700, Andrew Morton wrote: >> On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: >> >> > crash_kexec_post_notifiers enables running various panic notifier >> > before kdump kernel booting. This increases risks of kdump failur

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-21 Thread Konrad Rzeszutek Wilk
On Fri, Sep 18, 2020 at 05:47:43PM -0700, Andrew Morton wrote: > On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > > > crash_kexec_post_notifiers enables running various panic notifier > > before kdump kernel booting. This increases risks of kdump failure. > > It is well documented in kernel

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-19 Thread Dave Young
On 09/18/20 at 05:47pm, Andrew Morton wrote: > On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > > > crash_kexec_post_notifiers enables running various panic notifier > > before kdump kernel booting. This increases risks of kdump failure. > > It is well documented in kernel-parameters.txt. W

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-18 Thread Andrew Morton
On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > crash_kexec_post_notifiers enables running various panic notifier > before kdump kernel booting. This increases risks of kdump failure. > It is well documented in kernel-parameters.txt. We do not suggest > people to enable it together with kd

[PATCH] Only allow to set crash_kexec_post_notifiers on boot time

2020-09-17 Thread Dave Young
crash_kexec_post_notifiers enables running various panic notifier before kdump kernel booting. This increases risks of kdump failure. It is well documented in kernel-parameters.txt. We do not suggest people to enable it together with kdump unless he/she is really sure. This is also not suggested to