Re: [PATCH] New user space serial port driver

2000-12-07 Thread Jamie Lokier
Pavel Machek wrote: > > Please consider including this user space serial driver. It was writen for > > the Pele 833 RAS Server but is also usable for other serial device drivers > > in user space. > > Good, someone finally implemented this. This is going to be mandatory > if we want to support wi

Re: [PATCH] New user space serial port driver

2000-12-04 Thread Pavel Machek
Hi! > Please consider including this user space serial driver. It was writen for > the Pele 833 RAS Server but is also usable for other serial device drivers > in user space. Good, someone finally implemented this. This is going to be mandatory if we want to support winmodems properly; also ISDN

Re: [PATCH] New user space serial port driver

2000-11-30 Thread Rogier Wolff
Russell King wrote: > Rogier Wolff writes: > > Documentation bug. Not code bug. > > In which case, can we put it in as a documentation fix rather than changing > the compiler output? ie, /* = { NULL, } */ ? Because I care more about the 4 bytes of extra source than the 4 bytes of extra object.

Re: [PATCH] New user space serial port driver

2000-11-30 Thread Russell King
Rogier Wolff writes: > Documentation bug. Not code bug. In which case, can we put it in as a documentation fix rather than changing the compiler output? ie, /* = { NULL, } */ ? _ |_| - ---+---+- | | Russell King[EM

Re: [PATCH] New user space serial port driver

2000-11-30 Thread Rogier Wolff
Russell King wrote: > Rogier Wolff writes: > > > > +static struct termios* ussp_termios[USSP_MAX_PORTS]; > > > > +static struct termios* ussp_termios_locked[USSP_MAX_PORTS]; > > > > this SHOULD mean that these are first initialized before use. > > > > If you think they can be used befor

Re: [PATCH] New user space serial port driver

2000-11-30 Thread Russell King
Rogier Wolff writes: > > > +static struct termios* ussp_termios[USSP_MAX_PORTS]; > > > +static struct termios* ussp_termios_locked[USSP_MAX_PORTS]; > > this SHOULD mean that these are first initialized before use. > > If you think they can be used before first being initialized by the >

Re: [PATCH] New user space serial port driver

2000-11-30 Thread Rogier Wolff
Tigran Aivazian wrote: > On Thu, 30 Nov 2000, Patrick van de Lageweg wrote: > > +static struct tty_struct * ussp_table[USSP_MAX_PORTS] = { NULL, }; > > this wastes at least 4 * USSP_MAX_PORTS bytes in the kernel image. > Typically around 64 bytes but could be more. For more info see the recent >

Re: [PATCH] New user space serial port driver

2000-11-30 Thread Tigran Aivazian
On Thu, 30 Nov 2000, Patrick van de Lageweg wrote: > +static struct tty_struct * ussp_table[USSP_MAX_PORTS] = { NULL, }; this wastes at least 4 * USSP_MAX_PORTS bytes in the kernel image. Typically around 64 bytes but could be more. For more info see the recent silly flamewars on the list. The co

[PATCH] New user space serial port driver

2000-11-29 Thread Patrick van de Lageweg
Hi Linus, Please consider including this user space serial driver. It was writen for the Pele 833 RAS Server but is also usable for other serial device drivers in user space. Patrick diff -u -r --new-file linux-2.4.0-test7.clean/Documentation/Configure.help linux-2.4.0-test7.rio/Do