Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-13 Thread Folkert van Heusden
>>> The patch below contains a small code clean-up for the NTFS driver: all >>> static char pointers to error message strings have been replaced by >>> static char arrays. While doing that clean-up, shouldn't these be converted as well? [EMAIL PROTECTED]:/usr/src/linux$ find . -name \*.c -print0

Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-09 Thread Ahmed S. Darwish
On Tue, Oct 09, 2007 at 08:33:59PM +0200, Philipp Matthias Hahn wrote: > Hello! > > On Tue, Oct 09, 2007 at 02:40:35PM +0200, Ahmed S. Darwish wrote: > > On Tue, Oct 09, 2007 at 01:55:42AM +0400, Dmitri Vorobiev wrote: > > > The patch below contains a small code clean-up for the NTFS driver: all >

Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-09 Thread Philipp Matthias Hahn
Hello! On Tue, Oct 09, 2007 at 02:40:35PM +0200, Ahmed S. Darwish wrote: > On Tue, Oct 09, 2007 at 01:55:42AM +0400, Dmitri Vorobiev wrote: > > The patch below contains a small code clean-up for the NTFS driver: all > > static char pointers to error message strings have been replaced by > > stati

Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-09 Thread Dmitri Vorobiev
Ahmed S. Darwish wrote: On Tue, Oct 09, 2007 at 01:55:42AM +0400, Dmitri Vorobiev wrote: Hi, The patch below contains a small code clean-up for the NTFS driver: all static char pointers to error message strings have been replaced by static char arrays. Hi Dmitri, Hi, First off, I hate t

Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-09 Thread Ahmed S. Darwish
On Tue, Oct 09, 2007 at 01:55:42AM +0400, Dmitri Vorobiev wrote: > Hi, > > The patch below contains a small code clean-up for the NTFS driver: all > static char pointers to error message strings have been replaced by > static char arrays. > Hi Dmitri, Isn't the only difference between char *c

[PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-08 Thread Dmitri Vorobiev
Hi, The patch below contains a small code clean-up for the NTFS driver: all static char pointers to error message strings have been replaced by static char arrays. Please apply if you like it. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> --- diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attri