Re: [PATCH] NMI/CMOS RTC race fix for x86-64

2005-03-07 Thread Corey Minyard
Patch is attached. Thanks. -Corey Andi Kleen wrote: But in this case it isnt. Instead of all this complexity just remove the NMI reassert code from the NMI handler. It is oudated and mostly useless on modern systems anyways. "mostly useless" and "completely useless" are two different thin

Re: [PATCH] NMI/CMOS RTC race fix for x86-64

2005-03-07 Thread Andi Kleen
> >But in this case it isnt. Instead of all this complexity > >just remove the NMI reassert code from the NMI handler. > >It is oudated and mostly useless on modern systems anyways. > > > > > "mostly useless" and "completely useless" are two different things. It's completely useless (double chec

Re: [PATCH] NMI/CMOS RTC race fix for x86-64

2005-03-07 Thread Corey Minyard
Andi Kleen wrote: Corey Minyard <[EMAIL PROTECTED]> writes: This patch fixes a race between the CMOS clock setting and the NMI code. The NMI code indiscriminatly sets index registers and values in the same place the CMOS clock is set. If you are setting the CMOS clock and an NMI occurs, Bad va

Re: [PATCH] NMI/CMOS RTC race fix for x86-64

2005-03-07 Thread Andi Kleen
Corey Minyard <[EMAIL PROTECTED]> writes: > This patch fixes a race between the CMOS clock setting and the NMI > code. The NMI code indiscriminatly sets index registers and values > in the same place the CMOS clock is set. If you are setting the > CMOS clock and an NMI occurs, Bad values could b

[PATCH] NMI/CMOS RTC race fix for x86-64

2005-03-07 Thread Corey Minyard
This patch fixes a race between the CMOS clock setting and the NMI code. The NMI code indiscriminatly sets index registers and values in the same place the CMOS clock is set. If you are setting the CMOS clock and an NMI occurs, Bad values could be written to or read from the CMOS RAM, or the NMI