Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread NeilBrown
On Mon, Nov 16 2020, Trond Myklebust wrote: > On Mon, 2020-11-16 at 16:12 +1100, NeilBrown wrote: >> On Mon, Nov 16 2020, Trond Myklebust wrote: >> >> > On Mon, 2020-11-16 at 16:00 +1100, NeilBrown wrote: >> > > On Mon, Nov 16 2020, Trond Myklebust wrote: >> > > >> > > > On Mon, 2020-11-16 at 15

Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread Trond Myklebust
On Mon, 2020-11-16 at 16:12 +1100, NeilBrown wrote: > On Mon, Nov 16 2020, Trond Myklebust wrote: > > > On Mon, 2020-11-16 at 16:00 +1100, NeilBrown wrote: > > > On Mon, Nov 16 2020, Trond Myklebust wrote: > > > > > > > On Mon, 2020-11-16 at 15:43 +1100, NeilBrown wrote: > > > > > On Mon, Nov 16

Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread NeilBrown
On Mon, Nov 16 2020, Trond Myklebust wrote: > On Mon, 2020-11-16 at 16:00 +1100, NeilBrown wrote: >> On Mon, Nov 16 2020, Trond Myklebust wrote: >> >> > On Mon, 2020-11-16 at 15:43 +1100, NeilBrown wrote: >> > > On Mon, Nov 16 2020, Trond Myklebust wrote: >> > > >> > > > On Mon, 2020-11-16 at 13

Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread Trond Myklebust
On Mon, 2020-11-16 at 16:00 +1100, NeilBrown wrote: > On Mon, Nov 16 2020, Trond Myklebust wrote: > > > On Mon, 2020-11-16 at 15:43 +1100, NeilBrown wrote: > > > On Mon, Nov 16 2020, Trond Myklebust wrote: > > > > > > > On Mon, 2020-11-16 at 13:59 +1100, NeilBrown wrote: > > > > > > > > > > Prio

Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread NeilBrown
On Mon, Nov 16 2020, Trond Myklebust wrote: > On Mon, 2020-11-16 at 15:43 +1100, NeilBrown wrote: >> On Mon, Nov 16 2020, Trond Myklebust wrote: >> >> > On Mon, 2020-11-16 at 13:59 +1100, NeilBrown wrote: >> > > >> > > Prior to commit 5ceb9d7fdaaf ("NFS: Refactor >> > > nfs_lookup_revalidate()")

Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread Trond Myklebust
On Mon, 2020-11-16 at 15:43 +1100, NeilBrown wrote: > On Mon, Nov 16 2020, Trond Myklebust wrote: > > > On Mon, 2020-11-16 at 13:59 +1100, NeilBrown wrote: > > > > > > Prior to commit 5ceb9d7fdaaf ("NFS: Refactor > > > nfs_lookup_revalidate()") > > > and error from nfs_lookup_verify_inode() other

Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread NeilBrown
On Mon, Nov 16 2020, Trond Myklebust wrote: > On Mon, 2020-11-16 at 13:59 +1100, NeilBrown wrote: >> >> Prior to commit 5ceb9d7fdaaf ("NFS: Refactor >> nfs_lookup_revalidate()") >> and error from nfs_lookup_verify_inode() other than -ESTALE would >> result >> in nfs_lookup_revalidate() returning

Re: [PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread Trond Myklebust
On Mon, 2020-11-16 at 13:59 +1100, NeilBrown wrote: > > Prior to commit 5ceb9d7fdaaf ("NFS: Refactor > nfs_lookup_revalidate()") > and error from nfs_lookup_verify_inode() other than -ESTALE would > result > in nfs_lookup_revalidate() returning that error code (-ESTALE is > mapped > to zero). > Si

[PATCH] NFS: only invalidate dentrys that are clearly invalid.

2020-11-15 Thread NeilBrown
Prior to commit 5ceb9d7fdaaf ("NFS: Refactor nfs_lookup_revalidate()") and error from nfs_lookup_verify_inode() other than -ESTALE would result in nfs_lookup_revalidate() returning that error code (-ESTALE is mapped to zero). Since that commit, all errors result in zero being returned. When nfs_l

[PATCH] NFS: only invalidate dentrys that are clearly invalid.

2017-07-04 Thread NeilBrown
Since commit bafc9b754f75 ("vfs: More precise tests in d_invalidate") in v3.18, a return of '0' from ->d_revalidate() will cause the dentry to be invalidated even if it has filesystems mounted on or it or on a descendant. The mounted filesystem is unmounted. This means we need to be careful not