Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-05-24 Thread Wouter Verhelst
On Thu, May 19, 2016 at 08:35:03AM +0200, Markus Pargmann wrote: > Hi Wouter, > > On Sun, May 15, 2016 at 02:55:39PM +0200, Wouter Verhelst wrote: > > Hi Markus, > > > > On Thu, May 12, 2016 at 11:53:01AM +0200, Markus Pargmann wrote: > > > On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-05-18 Thread Markus Pargmann
Hi Wouter, On Sun, May 15, 2016 at 02:55:39PM +0200, Wouter Verhelst wrote: > Hi Markus, > > On Thu, May 12, 2016 at 11:53:01AM +0200, Markus Pargmann wrote: > > On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote: > > > However, at some point I agreed with Paul (your predecessor) that when

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-05-15 Thread Wouter Verhelst
Hi Markus, On Thu, May 12, 2016 at 11:53:01AM +0200, Markus Pargmann wrote: > On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote: > > However, at some point I agreed with Paul (your predecessor) that when > > this happens due to an error condition (as opposed to it being due to an > > explic

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-05-12 Thread Markus Pargmann
Hi, On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote: > On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote: > > Hi, > > > > On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: > > > Thanks for the review. > > > > > > Atleast for ext4 this crash happens on a sys_umount() c

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-05-10 Thread Paolo Bonzini
On 23/04/2016 04:17, Ratna Manoj wrote: > Ext4 can be fixed with the this patch: > http://www.spinics.net/lists/linux-ext4/msg51112.html > It did not make to the kernel. It checks the state of the buffer head > before committing. The patch did not make it, but Ted Ts'o proposed an alternative (

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-28 Thread Ratna Manoj
Hi, On Thursday 28 April 2016 09:57 PM, Wouter Verhelst wrote: > On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote: >> Hi, >> >> On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: >>> Thanks for the review. >>> >>> Atleast for ext4 this crash happens on a sys_umount() call, timi

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-28 Thread Wouter Verhelst
On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote: > Hi, > > On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: > > Thanks for the review. > > > > Atleast for ext4 this crash happens on a sys_umount() call, timing of > > which is not in control of block driver. Block driver cann

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-28 Thread Markus Pargmann
Hi, On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: > Thanks for the review. > > Atleast for ext4 this crash happens on a sys_umount() call, timing of > which is not in control of block driver. Block driver cannot force the > filesystems to be unmounted, and the file system does not expect

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-22 Thread Ratna Manoj
Thanks for the review. Atleast for ext4 this crash happens on a sys_umount() call, timing of which is not in control of block driver. Block driver cannot force the filesystems to be unmounted, and the file system does not expect buffers to get unmapped under it. Ext4 can be fixed with the this

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

2016-04-20 Thread Markus Pargmann
Hi, On Thursday 24 March 2016 07:04:10 Ratna Manoj wrote: > From: Ratna Manoj Bolla > > When a filesystem is mounted on a nbd device and on a disconnect, because > of kill_bdev(), and resetting bdev size to zero, buffer_head mappings are > getting destroyed under mounted filesystem. > > After