Re: [PATCH] Moved module init-functions into the module.

2017-06-22 Thread Steve Kemp
On Thu Jun 22, 2017 at 16:02:30 +0800, Ethan Zhao wrote: > Seems you moved the initialization of security module to > late_initcall stage, that is not right. Thanks for the feedback. > For security modules, you should use security_initcall() macro to define > the init functions.

Re: [PATCH] Moved module init-functions into the module.

2017-06-22 Thread Ethan Zhao
Steve, Seems you moved the initialization of security module to late_initcall stage, that is not right. Functions defined with late_initcall() macro will be done pretty late than security_init(). For security modules, you should use security_initcall() macro to define the init

[PATCH] Moved module init-functions into the module.

2017-06-22 Thread Steve Kemp
This commit moves the call to initialize the LSM modules inline into the LSM-files themselves. This removes the need to hunt around for the setup, which was something that bit me when I wrote my own (unrelated) LSM. Keeping LSM code in one place, including the setup of the hooks seems like a san