Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-26 Thread Li Zefan
Paul Menage wrote: > On Mon, Feb 25, 2008 at 7:01 PM, Li Zefan <[EMAIL PROTECTED]> wrote: >> > >> > - foo doesn't show up in /proc/cgroups >> >> Or we can print out the disable flag, maybe this will be better? >> Because we can distinguish from disabled and not compiled in from >> >> /proc/cgro

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-26 Thread Paul Menage
On Mon, Feb 25, 2008 at 7:01 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > > > > - foo doesn't show up in /proc/cgroups > > Or we can print out the disable flag, maybe this will be better? > Because we can distinguish from disabled and not compiled in from > > /proc/cgroups. Certainly possible, if

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Hirokazu Takahashi
Hi, > >>> I'll send out a prototype for comment. > > > > Something like the patch below. The effects of cgroup_disable=foo are: > > > > - foo doesn't show up in /proc/cgroups > > Or we can print out the disable flag, maybe this will be better? > Because we can distinguish from disabled and not

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Li Zefan
Paul Menage wrote: >>> I'll send out a prototype for comment. > > Something like the patch below. The effects of cgroup_disable=foo are: > > - foo doesn't show up in /proc/cgroups Or we can print out the disable flag, maybe this will be better? Because we can distinguish from disabled and not co

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Paul Menage
I'll send out a prototype for comment. Something like the patch below. The effects of cgroup_disable=foo are: - foo doesn't show up in /proc/cgroups - foo isn't auto-mounted if you mount all cgroups in a single hierarchy - foo isn't visible as an individually mountable subsystem As a result th

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Balbir Singh
Paul Menage wrote: > On Mon, Feb 25, 2008 at 9:18 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: >> I thought about it, but it did not work out all that well. The reason being, >> that the memory controller is called in from places besides cgroup. >> mem_cgroup_charge_common() for example is called

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Paul Menage
On Mon, Feb 25, 2008 at 9:18 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: > > I thought about it, but it did not work out all that well. The reason being, > that the memory controller is called in from places besides cgroup. > mem_cgroup_charge_common() for example is called from several places i

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Balbir Singh
Paul Menage wrote: > On Mon, Feb 25, 2008 at 3:55 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: >> >> A boot option for the memory controller was discussed on lkml. It is a good >> idea to add it, since it saves memory for people who want to turn off the >> memory controller. >> >> By default the

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Paul Menage
On Mon, Feb 25, 2008 at 3:55 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: > > > A boot option for the memory controller was discussed on lkml. It is a good > idea to add it, since it saves memory for people who want to turn off the > memory controller. > > By default the option is on for the fol

[PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Balbir Singh
A boot option for the memory controller was discussed on lkml. It is a good idea to add it, since it saves memory for people who want to turn off the memory controller. By default the option is on for the following two reasons 1. It provides compatibility with the current scheme where the memor