Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Eric W. Biederman
Ingo Molnar <[EMAIL PROTECTED]> writes: > * Eric W. Biederman <[EMAIL PROTECTED]> wrote: > >> >> Well struct pid * works in that case if you grab the reference to >> >> it. >> > >> > but the display of the stats might happen much later. The point of >> > this API is to save pid+comm, which gives

Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Ingo Molnar
* Eric W. Biederman <[EMAIL PROTECTED]> wrote: > >> Well struct pid * works in that case if you grab the reference to > >> it. > > > > but the display of the stats might happen much later. The point of > > this API is to save pid+comm, which gives users a good idea about > > what caused the ev

Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Eric W. Biederman
Ingo Molnar <[EMAIL PROTECTED]> writes: > * Eric W. Biederman <[EMAIL PROTECTED]> wrote: > >> > the problem is, this interface stores historic PIDs too - i.e. PIDs >> > of tasks that might have exited already. >> >> Well struct pid * works in that case if you grab the reference to it. > > but th

Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Ingo Molnar
* Eric W. Biederman <[EMAIL PROTECTED]> wrote: > > the problem is, this interface stores historic PIDs too - i.e. PIDs > > of tasks that might have exited already. > > Well struct pid * works in that case if you grab the reference to it. but the display of the stats might happen much later. Th

Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Eric W. Biederman
Ingo Molnar <[EMAIL PROTECTED]> writes: > * Eric W. Biederman <[EMAIL PROTECTED]> wrote: > >> > What the heck??? Please solve this properly instead of hiding it. >> > /proc/timer_stats is damn useful and it's a must-have for powertop >> > to work. >> >> Hmm. Perhaps the dependency conflict sho

Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Ingo Molnar
* Eric W. Biederman <[EMAIL PROTECTED]> wrote: > > What the heck??? Please solve this properly instead of hiding it. > > /proc/timer_stats is damn useful and it's a must-have for powertop > > to work. > > Hmm. Perhaps the dependency conflict should go in the other direction > then. > > My g

Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Eric W. Biederman
Ingo Molnar <[EMAIL PROTECTED]> writes: > * Eric W. Biederman <[EMAIL PROTECTED]> wrote: > >> /proc/timer_stats currently reports the user of a timer by pid, which >> is a reasonable approach. However if you are not in the initial pid >> namespace the pid that is reported is nonsense. >> >> Th

Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-13 Thread Ingo Molnar
* Eric W. Biederman <[EMAIL PROTECTED]> wrote: > /proc/timer_stats currently reports the user of a timer by pid, which > is a reasonable approach. However if you are not in the initial pid > namespace the pid that is reported is nonsense. > > Therefore until we can make timer_stats pid namesp

[PATCH] Mark timer_stats as incompatible with multiple pid namespaces

2007-12-12 Thread Eric W. Biederman
/proc/timer_stats currently reports the user of a timer by pid, which is a reasonable approach. However if you are not in the initial pid namespace the pid that is reported is nonsense. Therefore until we can make timer_stats pid namespace safe just disable it in the build if pid namespace suppo