Re: [PATCH] Makefile: fix GDB warning with CONFIG_RELR

2021-03-23 Thread Nathan Chancellor
On Thu, Mar 18, 2021 at 05:07:06PM -0700, Nick Desaulniers wrote: > GDB produces the following warning when debugging kernels built with > CONFIG_RELR: > > BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn' > > when loading a kernel built with CONFIG_RELR into GDB. It can

[PATCH] Makefile: fix GDB warning with CONFIG_RELR

2021-03-18 Thread Nick Desaulniers
GDB produces the following warning when debugging kernels built with CONFIG_RELR: BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn' when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations. Peter sugguests: [Th

Re: [PATCH] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-20 Thread Fangrui Song
On 2020-07-20, Nick Desaulniers wrote: On Mon, Jul 20, 2020 at 11:16 AM Nathan Chancellor wrote: On Mon, Jul 20, 2020 at 11:12:22AM -0700, Fangrui Song wrote: > When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if > $(CROSS_COMPILE)elfedit is found at /usr/bin/aarch64-linux-gnu-, > GCC_TOOL

Re: [PATCH] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-20 Thread Nick Desaulniers
On Mon, Jul 20, 2020 at 11:16 AM Nathan Chancellor wrote: > > On Mon, Jul 20, 2020 at 11:12:22AM -0700, Fangrui Song wrote: > > When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if > > $(CROSS_COMPILE)elfedit is found at /usr/bin/aarch64-linux-gnu-, > > GCC_TOOLCHAIN_DIR will be set to /usr/bin

Re: [PATCH] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-20 Thread Nathan Chancellor
On Mon, Jul 20, 2020 at 11:12:22AM -0700, Fangrui Song wrote: > When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if > $(CROSS_COMPILE)elfedit is found at /usr/bin/aarch64-linux-gnu-, > GCC_TOOLCHAIN_DIR will be set to /usr/bin/. --prefix= will be set to > /usr/bin/ and Clang as of 11 will sear

[PATCH] Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation

2020-07-20 Thread Fangrui Song
When CROSS_COMPILE is set (e.g. aarch64-linux-gnu-), if $(CROSS_COMPILE)elfedit is found at /usr/bin/aarch64-linux-gnu-, GCC_TOOLCHAIN_DIR will be set to /usr/bin/. --prefix= will be set to /usr/bin/ and Clang as of 11 will search for both $(prefix)aarch64-linux-gnu-$needle and $(prefix)$needle.

Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

2019-06-03 Thread George G. Davis
Hello Masahiro, On Sat, Jun 01, 2019 at 11:09:15AM +0900, Masahiro Yamada wrote: > On Sat, Jun 1, 2019 at 2:45 AM George G. Davis > wrote: > > > Following this pattern, does this work for you? > > > > > > diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl > > > index 122aef5e4e14..371bd1

Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

2019-05-31 Thread Masahiro Yamada
On Sat, Jun 1, 2019 at 2:45 AM George G. Davis wrote: > > Following this pattern, does this work for you? > > > > diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl > > index 122aef5e4e14..371bd17a4983 100755 > > --- a/scripts/checkstack.pl > > +++ b/scripts/checkstack.pl > > @@ -46,7 +46,

Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

2019-05-31 Thread George G. Davis
Hello Masahiro, On Sat, Jun 01, 2019 at 02:22:36AM +0900, Masahiro Yamada wrote: // CUT > As far as I understood, checkstack.pl is supposed to > understand both ARCH= and 'uname -m'. > > > For example, the following commit supports x86, x86_64, i386, > by using regular expression. > > commit

Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

2019-05-31 Thread Masahiro Yamada
On Sat, Jun 1, 2019 at 1:39 AM George G. Davis wrote: > > Hello Masahiro, > > On Sat, Jun 01, 2019 at 01:02:37AM +0900, Masahiro Yamada wrote: > > On Sat, Jun 1, 2019 at 12:27 AM George G. Davis > > wrote: > > > > > > The following error occurs for the `make ARCH=arm64 checkstack` case: > > > >

Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

2019-05-31 Thread George G. Davis
Hello Masahiro, On Sat, Jun 01, 2019 at 01:02:37AM +0900, Masahiro Yamada wrote: > On Sat, Jun 1, 2019 at 12:27 AM George G. Davis > wrote: > > > > The following error occurs for the `make ARCH=arm64 checkstack` case: > > > > aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \ > > pe

Re: [RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

2019-05-31 Thread Masahiro Yamada
On Sat, Jun 1, 2019 at 12:27 AM George G. Davis wrote: > > The following error occurs for the `make ARCH=arm64 checkstack` case: > > aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \ > perl ./scripts/checkstack.pl arm64 > wrong or unknown architecture "arm64" > > Fix the above error

[RFC][PATCH] Makefile: Fix checkstack.pl arm64 wrong or unknown architecture

2019-05-31 Thread George G. Davis
The following error occurs for the `make ARCH=arm64 checkstack` case: aarch64-linux-gnu-objdump -d vmlinux $(find . -name '*.ko') | \ perl ./scripts/checkstack.pl arm64 wrong or unknown architecture "arm64" Fix the above error by setting `CHECKSTACK_ARCH := aarch64` for the ARCH=arm64 case. Sign

Re: [PATCH] Makefile: Fix typo s/HOST_LOADLIBES/HOST_LOADLIBS

2018-04-24 Thread Masahiro Yamada
2018-04-25 0:59 GMT+09:00 Sedat Dilek : >> Masahiro Yamada hat am 24. April 2018 um >> 17:51 geschrieben: >> >> >> 2018-04-24 17:44 GMT+09:00 Sedat Dilek : >> > Signed-off-by: Sedat Dilek >> > --- >> > Makefile | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git

Re: [PATCH] Makefile: Fix typo s/HOST_LOADLIBES/HOST_LOADLIBS

2018-04-24 Thread Sedat Dilek
> Masahiro Yamada hat am 24. April 2018 um > 17:51 geschrieben: > > > 2018-04-24 17:44 GMT+09:00 Sedat Dilek : > > Signed-off-by: Sedat Dilek > > --- > > Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 83b6c541565a..e18

Re: [PATCH] Makefile: Fix typo s/HOST_LOADLIBES/HOST_LOADLIBS

2018-04-24 Thread Masahiro Yamada
2018-04-24 17:44 GMT+09:00 Sedat Dilek : > Signed-off-by: Sedat Dilek > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 83b6c541565a..e1869dc08288 100644 > --- a/Makefile > +++ b/Makefile > @@ -366,7 +366,7 @@ HOSTCFLAGS :=

[PATCH] Makefile: Fix typo s/HOST_LOADLIBES/HOST_LOADLIBS

2018-04-24 Thread Sedat Dilek
Signed-off-by: Sedat Dilek --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 83b6c541565a..e1869dc08288 100644 --- a/Makefile +++ b/Makefile @@ -366,7 +366,7 @@ HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \

[PATCH] Makefile: Fix lying comment re. silentoldconfig

2018-02-12 Thread Ulf Magnusson
The comment above the silentoldconfig invocation is outdated. 'make oldconfig' updates just .config and doesn't touch the include/config/ tree. This came up in https://lkml.org/lkml/2018/2/12/415. While fixing the comment, make it more informative by explaining the purpose of the unfortunately na

[PATCH] Makefile: Fix empty flag results for stackprotector _AUTO mode

2017-10-15 Thread Kees Cook
If the compiler didn't support any stackprotector mode, the second empty test would still trip. This moves it to an "else" test for the non-AUTO modes. Reported-and-tested-by: Robert Jarzmik Signed-off-by: Kees Cook --- This is a separate fix from the issue with gcc 4.4.4. Yay compilers. (Also,

[PATCH] Makefile: Fix CONFIG_CC_STACKPROTECTOR_AUTO to not enable SSP

2017-10-03 Thread Kees Cook
There was a think-o in the logic for CONFIG_CC_STACKPROTECTOR_AUTO, which would leave CONFIG_CC_STACKPROTECTOR defined when a compiler didn't support stack-protector. This usually won't cause a problem with a build, but it's not correct, and shouldn't happen. Reported-by: Mark Rutland Cc: Masahir

[PATCH] Makefile: fix reference to sparse documentation

2016-10-15 Thread Andreas Platschek
Documenation/sparse.txt was moved to Documentation/dev-tools/sparse.rst, this fixes the reference. Signed-off-by: Andreas Platschek --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d8c784d..d7157a1 100644 --- a/Makefile +++ b/Makefile @@

Re: [PATCH] Makefile: Fix detection of clang when cross-compiling

2015-04-11 Thread Michal Marek
On Thu, Apr 09, 2015 at 04:34:54PM +0200, Paul Cercueil wrote: > When the host's C compiler is clang, and when attempting to > cross-compile Linux e.g. to MIPS with mipsel-linux-gcc, the Makefile > would incorrectly detect the use of clang, which resulted in > clang-specific flags being passed to m

[PATCH] Makefile: Fix detection of clang when cross-compiling

2015-04-09 Thread Paul Cercueil
When the host's C compiler is clang, and when attempting to cross-compile Linux e.g. to MIPS with mipsel-linux-gcc, the Makefile would incorrectly detect the use of clang, which resulted in clang-specific flags being passed to mipsel-linux-gcc. This can be verified under Debian by installing the "

Re: [PATCH] Makefile: Fix unrecognized cross-compiler command line options

2014-06-09 Thread Michal Marek
Dne 27.5.2014 09:54, Geert Uytterhoeven napsal(a): > On architectures that setup CROSS_COMPILE in their arch/*/Makefile > (arc, blackfin, m68k, mips, parisc, score, sh, tile, unicore32, xtensa), > cc-option and cc-disable-warning may check against the wrong compiler, > causing errors like > >

[PATCH] Makefile: Fix unrecognized cross-compiler command line options

2014-05-27 Thread Geert Uytterhoeven
On architectures that setup CROSS_COMPILE in their arch/*/Makefile (arc, blackfin, m68k, mips, parisc, score, sh, tile, unicore32, xtensa), cc-option and cc-disable-warning may check against the wrong compiler, causing errors like cc1: error: unrecognized command line option "-Wno-maybe-uninit

Re: [PATCH] Makefile: fix syntax error in warning message

2014-02-20 Thread Kees Cook
On Wed, Feb 19, 2014 at 2:13 PM, wrote: > From: Stefan Seyfried > > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 893d6f0..eeaf3e7 100644 > --- a/Makefile > +++ b/Makefile > @@ -606,7 +606,7 @@ ifdef CONFIG_CC_STACKPROTECTOR_

[PATCH] Makefile: fix syntax error in warning message

2014-02-19 Thread stefan . seyfried
From: Stefan Seyfried --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 893d6f0..eeaf3e7 100644 --- a/Makefile +++ b/Makefile @@ -606,7 +606,7 @@ ifdef CONFIG_CC_STACKPROTECTOR_REGULAR stackp-flag := -fstack-protector ifeq ($(call cc

Re: [PATCH] Makefile: fix extra parenthesis typo when CC_STACKPROTECTOR_REGULAR is enabled

2014-02-18 Thread Kees Cook
On Mon, Feb 17, 2014 at 1:42 AM, Fathi Boudra wrote: > extra parenthesis typo introduced in commit 19952a9203 is causing > the following error when CONFIG_CC_STACKPROTECTOR_REGULAR is enabled: > Makefile:608: Cannot use CONFIG_CC_STACKPROTECTOR: -fstack-protector not > supported by compiler > Make

[PATCH] Makefile: fix order of INITRD_COMPRESS-y assignments

2013-12-20 Thread Jeff Layton
Commit 7ac181568342ec (fix build with make 3.80) changed how the Makefile handles the INITRD_COMPRESS-y assignment in order to make it work properly with older versions of make. Unfortunately, it also changes the behavior of how that assignment works when multiple CONFIG_RD_* options are set, such

[PATCH] Makefile: fix out-of-tree builds for multiple targets with 'all'

2013-11-03 Thread Yann E. MORIN
From: "Yann E. MORIN" For out-of-tree builds, this use-case fails to build: $ make clean all This is because 'all' is filtered-out in the Makefile wrapper, since the wrapper itself has a 'all' target. The 'all' target is just the usual naming for the default target in a Makefile. In fact, t

Re: [PATCH] Makefile: Fix install error with make -j option

2013-07-03 Thread Michal Marek
On Wed, Jun 12, 2013 at 12:13:47PM +0200, Robert Richter wrote: > Michal, > > please apply this fix, ideally for v3.10 if possible. I applied it to kbuild.git#kbuild now, with Cc: . Michal > > Thanks, > > -Robert > > > On 02.05.13 08:50:37, Robert Richter wrote: > > From: Robert Richter > >

Re: [PATCH] Makefile: Fix install error with make -j option

2013-06-12 Thread Robert Richter
Michal, please apply this fix, ideally for v3.10 if possible. Thanks, -Robert On 02.05.13 08:50:37, Robert Richter wrote: > From: Robert Richter > > Make modules_install fails with -j option: > >DEPMOD > Usage: .../.source/linux/scripts/depmod.sh /sbin/depmod > make[1]: *** [_modinst

[PATCH] Makefile: Fix install error with make -j option

2013-05-02 Thread Robert Richter
From: Robert Richter Make modules_install fails with -j option: DEPMOD Usage: .../.source/linux/scripts/depmod.sh /sbin/depmod make[1]: *** [_modinst_post] Error 1 Adding kernelrelease dependency to fix this. Signed-off-by: Robert Richter --- Makefile | 2 +- 1 file changed, 1 insertio

Re: [PATCH[ Makefile: Fix scripts_basic / archscripts build order

2012-09-20 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 9/19/12 1:42 PM, H. Peter Anvin wrote: > Kbuild people, any comments? Thanks for bouncing along. This patch is wrong. It fixes the 'make' case because scripts_basic is build before archscripts but doesn't get rid of the root cause. 'make archscri

Re: [PATCH[ Makefile: Fix scripts_basic / archscripts build order

2012-09-19 Thread H. Peter Anvin
Kbuild people, any comments? On 09/19/2012 10:38 AM, Jeff Mahoney wrote: > The SUSE kernel packages are built by doing the following: > > make silentoldonfig > make prepare > make scripts > make clean > > > > make -j$NCPUs > > On parallel builds (also using -C/O=), this can occasionally fail

[PATCH[ Makefile: Fix scripts_basic / archscripts build order

2012-09-19 Thread Jeff Mahoney
The SUSE kernel packages are built by doing the following: make silentoldonfig make prepare make scripts make clean make -j$NCPUs On parallel builds (also using -C/O=), this can occasionally fail with: HOSTCC scripts/basic/fixdep /bin/sh: scripts/basic/fixdep: No such file or directory

Re: [Git Patch] Makefile: fix wrong dirs when making cscope

2007-11-04 Thread WANG Cong
On Mon, Nov 05, 2007 at 08:33:17AM +0100, Sam Ravnborg wrote: >Hi Wang. > >Thanks for this fix, but I have a few comments. See below. > >On Mon, Nov 05, 2007 at 03:09:53PM +0800, WANG Cong wrote: >> >> Hi, Sam! >> >> This patch fixed the following errors when doing "make cscope" and >> "make csco

Re: [Git Patch] Makefile: fix wrong dirs when making cscope

2007-11-04 Thread Sam Ravnborg
Hi Wang. Thanks for this fix, but I have a few comments. See below. On Mon, Nov 05, 2007 at 03:09:53PM +0800, WANG Cong wrote: > > Hi, Sam! > > This patch fixed the following errors when doing "make cscope" and > "make cscope ARCH=um". > > FILELST cscope.files > find: arch/i386: No such file

[Git Patch] Makefile: fix wrong dirs when making cscope

2007-11-04 Thread WANG Cong
Hi, Sam! This patch fixed the following errors when doing "make cscope" and "make cscope ARCH=um". FILELST cscope.files find: arch/i386: No such file or directory MAKEcscope.out FILELST cscope.files find: include/asm-i386: No such file or directory MAKEcscope.out Signed-off-b

Re: [-mm patch] Makefile: fix spaces instead of tab

2005-04-05 Thread Sam Ravnborg
On Tue, Apr 05, 2005 at 02:21:57PM +0200, Adrian Bunk wrote: > GNU Emacs correctly complains because of spaces instead of a tab. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- linux-2.6.12-rc2-mm1-full/Makefile.old2005-04-05 14:00:06.0 > +0200 > +++ linux-2.6.12-rc2-mm1-f

[-mm patch] Makefile: fix spaces instead of tab

2005-04-05 Thread Adrian Bunk
On Tue, Apr 05, 2005 at 12:05:24AM -0700, Andrew Morton wrote: >... > Changes since 2.6.12-rc1-mm4: >... > bk-kbuild.patch >... GNU Emacs correctly complains because of spaces instead of a tab. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm1-full/Makefile.old 2005-

[PATCH] Makefile fix for FORE 200e and a typo in lec.c

2001-01-02 Thread Jan Rekorajski
Hi, The Fore dirver in 2.4.0-prerelease just does not build with the current makefile. This patch fixes it (works for me): --- linux/drivers/atm/Makefile.orig Tue Jan 2 10:18:25 2001 +++ linux/drivers/atm/Makefile Tue Jan 2 12:00:05 2001 @@ -46,7 +46,7 @@ endif endif -obj-$(CONFIG_AT

[PATCH] Makefile fix for ieee1394

2001-01-01 Thread Andreas Bombe
Now that I've had the time to understand the new kernel makefile structure the patch Kai Germaschewski posted is indeed the correct fix (move include line up). Furthermore it builds an .o object in the static compiled case now. I don't see any reason to choose the .a format and most other driver

[PATCH] Makefile fix

2000-12-14 Thread Brian Gerst
This patch should be obviously correct. diff -urN linux-2.4.0t13p1/arch/i386/Makefile linux/arch/i386/Makefile --- linux-2.4.0t13p1/arch/i386/Makefile Thu Dec 14 20:54:41 2000 +++ linux/arch/i386/MakefileThu Dec 14 21:04:34 2000 @@ -91,7 +91,7 @@ ifdef CONFIG_MATH_EMULATION SUBDIRS += arc