Re: [PATCH] Makefile: Don't try to add '-fcatch-undefined-behavior' flag

2019-05-12 Thread Masahiro Yamada
On Thu, May 9, 2019 at 8:49 PM Nathan Chancellor wrote: > > This is no longer a valid option in clang, it was removed in 3.5, which > we don't support. > > https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 > > Signed-off-by: Nathan Chancellor > --- > > Let me kn

Re: [PATCH] Makefile: Don't try to add '-fcatch-undefined-behavior' flag

2019-05-09 Thread Nick Desaulniers
> On Thu, May 9, 2019 at 1:49 PM Nathan Chancellor > wrote: > > > > This is no longer a valid option in clang, it was removed in 3.5, which > > we don't support. > > > > https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 lol, good catch. Reviewed-by: Nick Desauln

Re: [PATCH] Makefile: Don't try to add '-fcatch-undefined-behavior' flag

2019-05-09 Thread Sedat Dilek
On Thu, May 9, 2019 at 1:49 PM Nathan Chancellor wrote: > > This is no longer a valid option in clang, it was removed in 3.5, which > we don't support. > > https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 > Cool. Can you test with -mglobal-merge (inverted -mno

Re: [PATCH] Makefile: Don't try to add '-fcatch-undefined-behavior' flag

2019-05-09 Thread Masahiro Yamada
On Thu, May 9, 2019 at 8:49 PM Nathan Chancellor wrote: > > This is no longer a valid option in clang, it was removed in 3.5, which > we don't support. > > https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 > > Signed-off-by: Nathan Chancellor > --- > > Let me kn

[PATCH] Makefile: Don't try to add '-fcatch-undefined-behavior' flag

2019-05-09 Thread Nathan Chancellor
This is no longer a valid option in clang, it was removed in 3.5, which we don't support. https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 Signed-off-by: Nathan Chancellor --- Let me know if you want this incremental to your patch. I figured it made more sens