Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

2008-02-25 Thread David Howells
Roman Zippel <[EMAIL PROTECTED]> wrote: > I would actually prefer to introduce an explicit API for signed 64 > divides to get rid of the temps completely Yeah, that's a better plan. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

2008-02-25 Thread Roman Zippel
Hi, On Thu, 21 Feb 2008, David Howells wrote: > The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make > it > instead hand 64-bit unsigned values. This gets rid of a couple of warnings. I would actually prefer to introduce an explicit API for signed 64 divides to get rid

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-23 Thread Thomas Gleixner
On Sat, 23 Feb 2008, Andrew Morton wrote: > > > Thomas, do you consider ntp to fall under git-hrt? > > > > I'll pick it up. > > > OK. And this is still > git+ssh://master.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-hrt.git#mm, > yes? Yes > Can we please define the scope of that tree?

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-23 Thread Andrew Morton
On Sat, 23 Feb 2008 22:01:55 +0100 (CET) Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Sat, 23 Feb 2008, Andrew Morton wrote: > > > On Thu, 21 Feb 2008 16:50:35 + David Howells <[EMAIL PROTECTED]> wrote: > > > > > From: David Howells <[EMAIL PROTECTED]> > > > > > > The kernel NTP code sh

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-23 Thread Thomas Gleixner
On Sat, 23 Feb 2008, Andrew Morton wrote: > On Thu, 21 Feb 2008 16:50:35 + David Howells <[EMAIL PROTECTED]> wrote: > > > From: David Howells <[EMAIL PROTECTED]> > > > > The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). > > Make it > > instead hand 64-bit unsigned valu

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-23 Thread Andrew Morton
On Thu, 21 Feb 2008 16:50:35 + David Howells <[EMAIL PROTECTED]> wrote: > From: David Howells <[EMAIL PROTECTED]> > > The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make > it > instead hand 64-bit unsigned values. This gets rid of a couple of warnings. On certain a

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #2]

2008-02-21 Thread David Howells
David Howells <[EMAIL PROTECTED]> wrote: > Subject: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to > do_div() [try #2] Ignore try #2. I forgot to commit the changes before mailing. David -- To unsubscribe from this list: send the line "unsubscribe lin

[PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #2]

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make it instead hand 64-bit unsigned values. This gets rid of a couple of warnings. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/time/ntp.c |8 +--- 1 files ch

[PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div() [try #3]

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make it instead hand 64-bit unsigned values. This gets rid of a couple of warnings. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/time/ntp.c | 12 +++- 1 file

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

2008-02-21 Thread David Howells
Andreas Schwab <[EMAIL PROTECTED]> wrote: > do_div previously modified temp64 by side effect, now it no longer does > that. Good point. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

2008-02-21 Thread Andreas Schwab
David Howells <[EMAIL PROTECTED]> writes: > if (time_offset < 0) { > - temp64 = -temp64; > - do_div(temp64, mtemp); > + utemp64 = -temp64; > + do_div(utemp64, mtemp); >

[PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

2008-02-21 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> The kernel NTP code shouldn't hand 64-bit *signed* values to do_div(). Make it instead hand 64-bit unsigned values. This gets rid of a couple of warnings. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/time/ntp.c |8 +--- 1 files ch