Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509

2014-01-16 Thread joeyli
於 四，2014-01-16 於 12:31 +，David Howells 提到： > > Are you asking for this to go upstream or into my devel-pekey branch? > > If upstream you want it to go upstream, I presume commit > d7ec435fdd03cfee70dba934ee384acc87bd6d00 doesn't fix the problem? > > David You are right. I tried the d7ec435

Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509

2014-01-16 Thread Rusty Russell
Michal Marek writes: > On 15.1.2014 05:39, Rusty Russell wrote: >> "Lee, Chun-Yi" writes: >>> From: Chun-Yi Lee >>> v2: >>> Using '$(shell /bin/pwd)' instead of '$(shell pwd)' for more reliable >>> between different shells >> >> Hmm, that's not a great test for equality. How about: >> >>

Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509

2014-01-16 Thread Michal Marek
On 15.1.2014 05:39, Rusty Russell wrote: > "Lee, Chun-Yi" writes: >> From: Chun-Yi Lee >> v2: >> Using '$(shell /bin/pwd)' instead of '$(shell pwd)' for more reliable >> between different shells > > Hmm, that's not a great test for equality. How about: > > ifneq ($(realpath .), $(realpath

Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509

2014-01-16 Thread David Howells
Lee, Chun-Yi wrote: > This issue was found in devel-pekey branch on linux-modsign.git tree. > The Are you asking for this to go upstream or into my devel-pekey branch? If upstream you want it to go upstream, I presume commit d7ec435fdd03cfee70dba934ee384acc87bd6d00 doesn't fix the problem? Dav

Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509

2014-01-15 Thread joeyli
於 三，2014-01-15 於 15:09 +1030，Rusty Russell 提到： > > > > v2: > > Using '$(shell /bin/pwd)' instead of '$(shell pwd)' for more > reliable > > between different shells > > Hmm, that's not a great test for equality. How about: > > ifneq ($(realpath .), $(realpath $(srctree))) > > That should co

Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509

2014-01-15 Thread Rusty Russell
Punting to David Howells... Cheers, Rusty. "Lee, Chun-Yi" writes: > From: Chun-Yi Lee > > This issue was found in devel-pekey branch on linux-modsign.git tree. > The > x509_certificate_list includes certificate twice when the > signing_key.x509 > already exists. > We can reproduce this issue by

[PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509

2014-01-08 Thread Lee, Chun-Yi
From: Chun-Yi Lee This issue was found in devel-pekey branch on linux-modsign.git tree. The x509_certificate_list includes certificate twice when the signing_key.x509 already exists. We can reproduce this issue by making kernel twice, the build log of second time looks like this: ... CHK k

Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509 already exists

2013-02-22 Thread joeyli
Hi David, Thanks for your review and point out! 於 四，2013-02-21 於 14:16 +，David Howells 提到： > > +ifneq ($(shell pwd), $(srctree)) > > How reliable is this, I wonder? > > David > My current shell is bash, and I tried the '$(shell pwd)' in Makefile works for grab the REAL path when the buil

Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509 already exists

2013-02-21 Thread David Howells
> +ifneq ($(shell pwd), $(srctree)) How reliable is this, I wonder? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at ht

[PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509 already exists

2013-02-21 Thread Chun-Yi Lee
This issue was found in devel-pekey branch on linux-modsign.git tree. The x509_certificate_list includes certificate twice when the signing_key.x509 already exists. We can reproduce this issue by making kernel twice, the build log of second time looks like this: ... CHK kernel/config_data.h