Re: [PATCH] MMC host class

2005-08-19 Thread Russell King
On Fri, Aug 19, 2005 at 08:14:27AM +0200, Pierre Ossman wrote: > * Things that assume there's a name for every kobject. The name is assigned when the host is added to the mmc subsystem, not when it's allocated. This is the same behaviour as other subsystems (eg, networking) and I don't see a prob

Re: [PATCH] MMC host class

2005-08-18 Thread Pierre Ossman
Russell King wrote: > >Hmm, I think I've gone back to preferring something similar to your >original approach actually. I've also included the IDR patch. > > > Ok. Just as long as it works. :) My two concerns are: * Things that assume there's a name for every kobject. * Things that assume th

Re: [PATCH] MMC host class

2005-08-18 Thread Russell King
On Mon, Aug 08, 2005 at 01:38:13PM +0200, Pierre Ossman wrote: > Russell King wrote: > >I still don't like the needless duplication. How about doing it this > >way (see the attached patch.) > > > >Note: I also intend to move MMC over to using an IDR for the host > >numbers, which is why we need to

Re: [PATCH] MMC host class

2005-08-08 Thread Pierre Ossman
Russell King wrote: > >I still don't like the needless duplication. How about doing it this >way (see the attached patch.) > >Note: I also intend to move MMC over to using an IDR for the host >numbers, which is why we need to setup the name at registration >time, not allocation time. > > > Thi

Re: [PATCH] MMC host class

2005-07-18 Thread Russell King
On Fri, Jul 15, 2005 at 10:21:43PM +0200, Pierre Ossman wrote: > Russell King wrote: > >Also note that since we have a class_dev, the mmc_host 'dev' field can > >be removed. However, we'll probably have to update the host drivers > >to do this, so it should be a separate patch. > > I believe ther

Re: [PATCH] MMC host class

2005-07-18 Thread Pierre Ossman
Russell King wrote: >On Fri, Jul 15, 2005 at 10:21:43PM +0200, Pierre Ossman wrote: > > >>Russell King wrote: >> >> >>>Also note that since we have a class_dev, the mmc_host 'dev' field can >>>be removed. However, we'll probably have to update the host drivers >>>to do this, so it should be

Re: [PATCH] MMC host class

2005-07-15 Thread Pierre Ossman
Russell King wrote: >The allocation function should initialise class_dev as much as possible. >The registration function should add the class device with the class >model. The unregistration should remove the class device from the class >model, but _not_ free it. The free function should drop th

Re: [PATCH] MMC host class

2005-07-15 Thread Pierre Ossman
Russell King wrote: >No no no no no. Repeat after me ten times. Empty or non-existant release >functions are bad and cause oopsen. I will not create code which does >this. > > Sorry. I thought it was a generic cleanup function and since nothing was allocated in the register function I didn't

Re: [PATCH] MMC host class

2005-07-15 Thread Russell King
On Wed, Jul 13, 2005 at 05:52:52PM +0200, Pierre Ossman wrote: > Create a mmc_host class to allow enumeration of MMC host controllers > even though they have no card(s) inserted. > > Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> > > (This will also allow cards to be enumerated by being able to

[PATCH] MMC host class

2005-07-13 Thread Pierre Ossman
Create a mmc_host class to allow enumeration of MMC host controllers even though they have no card(s) inserted. Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> (This will also allow cards to be enumerated by being able to find the hosts.) Index: linux-wbsd/drivers/mmc/mmc.h =