Re: [PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

2017-10-31 Thread James Hogan
On Tue, Oct 31, 2017 at 07:08:04AM +, James Hogan wrote: > On Tue, Oct 31, 2017 at 12:35:03AM -0500, Gustavo A. R. Silva wrote: > > Signed-off-by: Gustavo A. R. Silva > > Reviewed-by: James Hogan That should of course be: Reviewed-by: James Hogan

Re: [PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

2017-10-31 Thread James Hogan
On Tue, Oct 31, 2017 at 12:35:03AM -0500, Gustavo A. R. Silva wrote: > It seems that this is a typo error and the proper bit masking is > "RT | RS" instead of "RS | RS". > > This issue was detected with the help of Coccinelle. > > Reported-by: Julia Lawall May I suggest adding: Fixes: d6b3314b4

[PATCH] MIPS: microMIPS: Fix incorrect mask in insn_table_MM

2017-10-30 Thread Gustavo A. R. Silva
It seems that this is a typo error and the proper bit masking is "RT | RS" instead of "RS | RS". This issue was detected with the help of Coccinelle. Reported-by: Julia Lawall Signed-off-by: Gustavo A. R. Silva --- arch/mips/mm/uasm-micromips.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio