Re: [PATCH] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu

2021-01-11 Thread Alexander Sverdlin
Hello Menglong! Thank you for the fix! A small correction below: On 11/01/2021 12:36, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0' > can't be true. > > Fix this by change the type of 'r' and 'i' from 'unsigned in

[PATCH] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu

2021-01-11 Thread menglong8 . dong
From: Menglong Dong The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0' can't be true. Fix this by change the type of 'r' and 'i' from 'unsigned int' to 'int'. As 'i' won't be negative, this change works. Fixes: 64b139f97c01("MIPS: OCTEON: irq: add CIB and other fixes") Signed-