Re: [PATCH] Little memset_explicit optimisation

2018-11-27 Thread Joey Pabalinas
On Wed, Nov 28, 2018 at 06:32:27AM +, David CARLIER wrote: > Bad entrance with bad idea I m afraid :-) sorry for the noise. We all start somewhere, no worries :) -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] Little memset_explicit optimisation

2018-11-27 Thread David CARLIER
Bad entrance with bad idea I m afraid :-) sorry for the noise.

Re: Re: [PATCH] Little memset_explicit optimisation

2018-11-26 Thread Joey Pabalinas
On Mon, Nov 26, 2018 at 07:36:19PM +, David CARLIER wrote: > Sorry I m not used yet at all to LKML rules. > > So here a slight difference in assembly generated between the two > versions (amd64) : > ` > .loc 1 7 7 > leaq-12(%rbp), %rax > movq%rax, -8(%rbp) > -.loc 1

Re: [PATCH] Little memset_explicit optimisation

2018-11-26 Thread David CARLIER
Sorry I m not used yet at all to LKML rules. So here a slight difference in assembly generated between the two versions (amd64) : ` .loc 1 7 7 leaq-12(%rbp), %rax movq%rax, -8(%rbp) -.loc 1 11 2 +.loc 1 9 6 movq-8(%rbp), %rax movl$4, %edx movl

Re: [PATCH] Little memset_explicit optimisation

2018-11-26 Thread Joey Pabalinas
On Sat, Nov 24, 2018 at 12:35:43PM +, David CARLIER wrote: > Using the return value of memset for save/load sake. > > Signed-off-by: David Carlier > --- > lib/string.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/string.c b/lib/string.c > index 38e4ca08e757..

Re: [PATCH] Little memset_explicit optimisation

2018-11-26 Thread Andy Shevchenko
On Sat, Nov 24, 2018 at 03:35:05PM +, David CARLIER wrote: > Subject: [PATCH] memzero_explicit, optimisation for size. > > > Using the return value of memset for save/load sake. It's mangled, you, perhaps, need to use `git format-patch ...; git send-email ...` for sake of correctness.

Re: [PATCH] Little memset_explicit optimisation

2018-11-26 Thread Andy Shevchenko
On Sat, Nov 24, 2018 at 12:35:43PM +, David CARLIER wrote: > Hmm... Can we see the difference in assembly generation? -- With Best Regards, Andy Shevchenko

[PATCH] Little memset_explicit optimisation

2018-11-24 Thread David CARLIER
Subject: [PATCH] memzero_explicit, optimisation for size. Using the return value of memset for save/load sake. Signed-off-by: David Carlier --- lib/string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/string.c b/lib/string.c index 38e4ca08e757..92da04a0213b 10

[PATCH] Little memset_explicit optimisation

2018-11-24 Thread David CARLIER
0001-memzero_explicit-optimisation-for-size.patch Description: Binary data