Re: [PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported

2018-12-21 Thread Paolo Bonzini
On 21/12/18 11:06, Vitaly Kuznetsov wrote: >> Btw, I would prefer this without the >> >> default: break; >> >> as I don't think we'll ever add something there. > > "640K ought to be enough for anybody" :-) > > But in case you commit it as > > return index != MSR_IA32_MCG_EXT_CTL; > > I won't

Re: [PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported

2018-12-21 Thread Vitaly Kuznetsov
Radim Krčmář writes: > 2018-12-19 12:06+0100, Vitaly Kuznetsov: >> AMD doesn't seem to implement MSR_IA32_MCG_EXT_CTL and svm code in kvm >> knows nothing about it, however, this MSR is among emulated_msrs and >> thus returned with KVM_GET_MSR_INDEX_LIST. The consequent KVM_GET_MSRS, >> of course

Re: [PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported

2018-12-20 Thread Radim Krčmář
2018-12-19 12:06+0100, Vitaly Kuznetsov: > AMD doesn't seem to implement MSR_IA32_MCG_EXT_CTL and svm code in kvm > knows nothing about it, however, this MSR is among emulated_msrs and > thus returned with KVM_GET_MSR_INDEX_LIST. The consequent KVM_GET_MSRS, > of course, fails. > > Report the MSR

[PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported

2018-12-19 Thread Vitaly Kuznetsov
AMD doesn't seem to implement MSR_IA32_MCG_EXT_CTL and svm code in kvm knows nothing about it, however, this MSR is among emulated_msrs and thus returned with KVM_GET_MSR_INDEX_LIST. The consequent KVM_GET_MSRS, of course, fails. Report the MSR as unsupported to not confuse userspace. Signed-off-