Re: [PATCH] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset

2016-04-28 Thread Bruce Rogers
>>> On 4/28/2016 at 01:08 PM, Radim Kr*má* wrote: > 2016-04-22 12:56-0600, Bruce Rogers: >> Commit d28bc9dd25ce reversed the order of two lines which initialize cr0, >> allowing the current (old) cr0 value to mess up vcpu initialization. >> This was observed in the checks for cr0 X86_CR0_WP bit i

Re: [PATCH] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset

2016-04-28 Thread Radim Krčmář
2016-04-22 12:56-0600, Bruce Rogers: > Commit d28bc9dd25ce reversed the order of two lines which initialize cr0, > allowing the current (old) cr0 value to mess up vcpu initialization. > This was observed in the checks for cr0 X86_CR0_WP bit in the context of > kvm_mmu_reset_context(). Besides, sett

Re: [PATCH] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset

2016-04-22 Thread Greg KH
On Fri, Apr 22, 2016 at 12:56:03PM -0600, Bruce Rogers wrote: > Commit d28bc9dd25ce reversed the order of two lines which initialize cr0, > allowing the current (old) cr0 value to mess up vcpu initialization. > This was observed in the checks for cr0 X86_CR0_WP bit in the context of > kvm_mmu_reset

[PATCH] KVM: x86: fix ordering of cr0 initialization code in vmx_cpu_reset

2016-04-22 Thread Bruce Rogers
Commit d28bc9dd25ce reversed the order of two lines which initialize cr0, allowing the current (old) cr0 value to mess up vcpu initialization. This was observed in the checks for cr0 X86_CR0_WP bit in the context of kvm_mmu_reset_context(). Besides, setting vcpu->arch.cr0 after vmx_set_cr0() is com