RE: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-29 Thread Kang, Luwei
> >>> However, you should at least change the comment in vcpu_enter_guest > >>> to mention "before reading PIR" instead of "before reading PIR.ON". > >> > >> Will do that. I think the "checking PIR.ON" should be PID.ON. I will fix > >> it. > >> > > Hi Paolo, > > I reconsidered the comment in v

Re: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-29 Thread Paolo Bonzini
On 29/01/19 10:32, Kang, Luwei wrote: >>> However, you should at least change the comment in vcpu_enter_guest to >>> mention "before reading PIR" instead of "before reading PIR.ON". >> >> Will do that. I think the "checking PIR.ON" should be PID.ON. I will fix it. >> > Hi Paolo, > I reconsidere

RE: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-29 Thread Kang, Luwei
> > However, you should at least change the comment in vcpu_enter_guest to > > mention "before reading PIR" instead of "before reading PIR.ON". > > Will do that. I think the "checking PIR.ON" should be PID.ON. I will fix it. > Hi Paolo, I reconsidered the comment in vcpu_enter_guest() and thi

Re: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-28 Thread Paolo Bonzini
On 28/01/19 09:08, Kang, Luwei wrote: >> However, you should at least change the comment in vcpu_enter_guest to >> mention "before reading PIR" instead of "before reading >> PIR.ON". > > Will do that. I think the "checking PIR.ON" should be PID.ON. I will fix it. Yes. >> Alternatively, would it

RE: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-28 Thread Kang, Luwei
> > Some Posted-Interrupts from passthrough devices may be lost or > > overwritten when the vCPU is in runnable state. > > > > The SN (Suppress Notification) of PID (Posted Interrupt Descriptor) > > will be set when the vCPU is preempted (vCPU in KVM_MP_STATE_RUNNABLE > > state but not running on p

RE: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-27 Thread Kang, Luwei
> > Some Posted-Interrupts from passthrough devices may be lost or > > overwritten when the vCPU is in runnable state. > > > > The SN (Suppress Notification) of PID (Posted Interrupt Descriptor) > > will be set when the vCPU is preempted (vCPU in KVM_MP_STATE_RUNNABLE > > state but not running on p

Re: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-25 Thread Paolo Bonzini
On 18/01/19 07:34, Luwei Kang wrote: > Some Posted-Interrupts from passthrough devices may be lost or > overwritten when the vCPU is in runnable state. > > The SN (Suppress Notification) of PID (Posted Interrupt Descriptor) will > be set when the vCPU is preempted (vCPU in KVM_MP_STATE_RUNNABLE st

Re: [PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-25 Thread Konrad Rzeszutek Wilk
On Fri, Jan 18, 2019 at 02:34:00PM +0800, Luwei Kang wrote: > Some Posted-Interrupts from passthrough devices may be lost or > overwritten when the vCPU is in runnable state. > > The SN (Suppress Notification) of PID (Posted Interrupt Descriptor) will > be set when the vCPU is preempted (vCPU in K

[PATCH] KVM: x86: Sync the pending Posted-Interrupts

2019-01-17 Thread Luwei Kang
Some Posted-Interrupts from passthrough devices may be lost or overwritten when the vCPU is in runnable state. The SN (Suppress Notification) of PID (Posted Interrupt Descriptor) will be set when the vCPU is preempted (vCPU in KVM_MP_STATE_RUNNABLE state but not running on physical CPU). If a post