Re: [PATCH] KVM: x86/mmu: consider the hva in mmu_notifer retry

2021-01-26 Thread Sean Christopherson
On Tue, Jan 26, 2021, David Stevens wrote: > > This needs a comment to explicitly state that 'count > 1' cannot be done at > > this time. My initial thought is that it would be more intuitive to check > > for > > 'count > 1' here, but that would potentially check the wrong wrange when > > count

Re: [PATCH] KVM: x86/mmu: consider the hva in mmu_notifer retry

2021-01-26 Thread David Stevens
> > This has the secondary effect of greatly reducing the likelihood of extreme > > Out of curiosity, is this really the _secondary_ effect? I would expect this > change to primarily benefit scenarios where the invalidation has gotten > waylaid for whatever reason. Yeah, this is the primary benef

Re: [PATCH] KVM: x86/mmu: consider the hva in mmu_notifer retry

2021-01-25 Thread Sean Christopherson
+Cc the other architectures, I'm guessing this would be a helpful optimization for all archs. Quite a few comments, but they're all little more than nits. Nice! On Mon, Jan 25, 2021, David Stevens wrote: > From: David Stevens > > Use the range passed to mmu_notifer's invalidate_range_start to

[PATCH] KVM: x86/mmu: consider the hva in mmu_notifer retry

2021-01-24 Thread David Stevens
From: David Stevens Use the range passed to mmu_notifer's invalidate_range_start to prevent spurious page fault retries due to changes in unrelated host virtual addresses. This has the secondary effect of greatly reducing the likelihood of extreme latency when handing a page fault due to another