Re: [PATCH] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-21 Thread David Hildenbrand
On 21.08.2018 16:43, Janosch Frank wrote: > On 21.08.2018 16:19, Pierre Morel wrote: >> Copy the key mask to the right offset inside the shadow CRYCB >> >> Signed-off-by: Pierre Morel >> --- >> arch/s390/kvm/vsie.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch

Re: [PATCH] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-21 Thread Janosch Frank
On 21.08.2018 16:19, Pierre Morel wrote: > Copy the key mask to the right offset inside the shadow CRYCB > > Signed-off-by: Pierre Morel > --- > arch/s390/kvm/vsie.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c > index 63

Re: [PATCH] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-21 Thread Cornelia Huck
On Tue, 21 Aug 2018 16:36:19 +0200 David Hildenbrand wrote: > On 21.08.2018 16:33, Cornelia Huck wrote: > > On Tue, 21 Aug 2018 16:19:38 +0200 > > Pierre Morel wrote: > > > >> Copy the key mask to the right offset inside the shadow CRYCB > >> > >> Signed-off-by: Pierre Morel > >> --- > >> a

Re: [PATCH] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-21 Thread David Hildenbrand
On 21.08.2018 16:33, Cornelia Huck wrote: > On Tue, 21 Aug 2018 16:19:38 +0200 > Pierre Morel wrote: > >> Copy the key mask to the right offset inside the shadow CRYCB >> >> Signed-off-by: Pierre Morel >> --- >> arch/s390/kvm/vsie.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >>

Re: [PATCH] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-21 Thread Cornelia Huck
On Tue, 21 Aug 2018 16:19:38 +0200 Pierre Morel wrote: > Copy the key mask to the right offset inside the shadow CRYCB > > Signed-off-by: Pierre Morel > --- > arch/s390/kvm/vsie.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/v

Re: [PATCH] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-21 Thread David Hildenbrand
On 21.08.2018 16:19, Pierre Morel wrote: > Copy the key mask to the right offset inside the shadow CRYCB "KVM: s390: vsie: copy wrapping keys to right place" Indeed, we're writing it into the apcb0 mask (which is ignored). Luckily, the xor-ing with the g2 keys seems to work. Reviewed-by: David H

[PATCH] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-21 Thread Pierre Morel
Copy the key mask to the right offset inside the shadow CRYCB Signed-off-by: Pierre Morel --- arch/s390/kvm/vsie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c index 63844b9..a2b28cd 100644 --- a/arch/s390/kvm/vsie.c +++ b/arch