Re: [PATCH] KVM: arm64: fix misleading comments in save/restore

2015-06-04 Thread Marc Zyngier
On 04/06/15 11:46, Alex Bennée wrote: > > Marc Zyngier writes: > >> On 04/06/15 11:20, Alex Bennée wrote: >>> >>> Marc Zyngier writes: >>> On 04/06/15 10:34, Christoffer Dall wrote: > On Thu, May 28, 2015 at 10:43:06AM +0100, Alex Bennée wrote: >> The elr_el2 and spsr_el2 registers

Re: [PATCH] KVM: arm64: fix misleading comments in save/restore

2015-06-04 Thread Alex Bennée
Marc Zyngier writes: > On 04/06/15 11:20, Alex Bennée wrote: >> >> Marc Zyngier writes: >> >>> On 04/06/15 10:34, Christoffer Dall wrote: On Thu, May 28, 2015 at 10:43:06AM +0100, Alex Bennée wrote: > The elr_el2 and spsr_el2 registers in fact contain the processor state > before

Re: [PATCH] KVM: arm64: fix misleading comments in save/restore

2015-06-04 Thread Marc Zyngier
On 04/06/15 11:20, Alex Bennée wrote: > > Marc Zyngier writes: > >> On 04/06/15 10:34, Christoffer Dall wrote: >>> On Thu, May 28, 2015 at 10:43:06AM +0100, Alex Bennée wrote: The elr_el2 and spsr_el2 registers in fact contain the processor state before entry into the hypervisor code.

Re: [PATCH] KVM: arm64: fix misleading comments in save/restore

2015-06-04 Thread Alex Bennée
Marc Zyngier writes: > On 04/06/15 10:34, Christoffer Dall wrote: >> On Thu, May 28, 2015 at 10:43:06AM +0100, Alex Bennée wrote: >>> The elr_el2 and spsr_el2 registers in fact contain the processor state >>> before entry into the hypervisor code. >> >> be careful with your use of the hyperviso

Re: [PATCH] KVM: arm64: fix misleading comments in save/restore

2015-06-04 Thread Marc Zyngier
On 04/06/15 10:34, Christoffer Dall wrote: > On Thu, May 28, 2015 at 10:43:06AM +0100, Alex Bennée wrote: >> The elr_el2 and spsr_el2 registers in fact contain the processor state >> before entry into the hypervisor code. > > be careful with your use of the hypervisor, in the KVM design the > hype

Re: [PATCH] KVM: arm64: fix misleading comments in save/restore

2015-06-04 Thread Christoffer Dall
On Thu, May 28, 2015 at 10:43:06AM +0100, Alex Bennée wrote: > The elr_el2 and spsr_el2 registers in fact contain the processor state > before entry into the hypervisor code. be careful with your use of the hypervisor, in the KVM design the hypervisor is split across EL1 and EL2. > In the case of

[PATCH] KVM: arm64: fix misleading comments in save/restore

2015-05-28 Thread Alex Bennée
The elr_el2 and spsr_el2 registers in fact contain the processor state before entry into the hypervisor code. In the case of guest state it could be in either el0 or el1. Signed-off-by: Alex Bennée --- arch/arm64/kvm/hyp.S | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git