Re: [PATCH] KVM: VMX: check match table

2017-10-03 Thread Nick Desaulniers
- avi I think an extra `did not` made it in to that last email...sorry! On Tue, Oct 3, 2017 at 7:54 PM, Nick Desaulniers wrote: > On Tue, Oct 03, 2017 at 11:42:18AM +0200, Paolo Bonzini wrote: >> On 01/10/2017 01:22, Nick Desaulniers wrote: >> > I don't follow (but I also don't know what any of

Re: [PATCH] KVM: VMX: check match table

2017-10-03 Thread Nick Desaulniers
On Tue, Oct 03, 2017 at 11:42:18AM +0200, Paolo Bonzini wrote: > On 01/10/2017 01:22, Nick Desaulniers wrote: > > I don't follow (but I also don't know what any of these three letter > > acryonyms acronyms stand for), does svm depend on vmx or vice-versa? > Neither, one is Intel (VMX), the other is

Re: [PATCH] KVM: VMX: check match table

2017-10-03 Thread Paolo Bonzini
On 01/10/2017 01:22, Nick Desaulniers wrote: > On Wed, Sep 27, 2017 at 02:36:03PM +0200, Paolo Bonzini wrote: >> On 26/09/2017 19:12, Josh Triplett wrote: >>> Does this make any other checks redundant and removable? >> >> It would make sense to place it in cpu_has_kvm_support instead > > cpu_has_k

Re: [PATCH] KVM: VMX: check match table

2017-09-30 Thread Nick Desaulniers
On Wed, Sep 27, 2017 at 02:36:03PM +0200, Paolo Bonzini wrote: > On 26/09/2017 19:12, Josh Triplett wrote: > > Does this make any other checks redundant and removable? > > It would make sense to place it in cpu_has_kvm_support instead cpu_has_kvm_support() or cpu_has_vmx()? >, and the same in sv

Re: [PATCH] KVM: VMX: check match table

2017-09-27 Thread kbuild test robot
Hi Nick, [auto build test ERROR on kvm/linux-next] [also build test ERROR on v4.14-rc2 next-20170927] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nick-Desaulniers/KVM-VMX-check-match-table/20

Re: [PATCH] KVM: VMX: check match table

2017-09-27 Thread Paolo Bonzini
On 26/09/2017 19:12, Josh Triplett wrote: >> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >> index 6970249c09fc..e1a00b130935 100644 >> --- a/arch/x86/kvm/vmx.c >> +++ b/arch/x86/kvm/vmx.c >> @@ -12074,7 +12074,12 @@ static struct kvm_x86_ops vmx_x86_ops >> __ro_after_init = { >> >> sta

Re: [PATCH] KVM: VMX: check match table

2017-09-26 Thread Josh Triplett
On Mon, Sep 25, 2017 at 09:25:38PM -0700, Nick Desaulniers wrote: > Fixes the warning: > arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed > and will not be emitted [-Wunneeded-internal-declaration]`` > > Other callers of MODULE_DEVICE_TABLE() seem to check their second > argu

[PATCH] KVM: VMX: check match table

2017-09-25 Thread Nick Desaulniers
Fixes the warning: arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed and will not be emitted [-Wunneeded-internal-declaration]`` Other callers of MODULE_DEVICE_TABLE() seem to check their second argument during driver init with the x86_match_cpu() function, if their first argu