Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-23 Thread Wanpeng Li
d2017-11-23 0:56 GMT+08:00 Paolo Bonzini : > On 22/11/2017 10:43, Liran Alon wrote: I think we should also set "vmx->nested.smm.vmxon = false;" after "vmx->nested.vmxon = false;" to correctlyhandle the case VMXOFF is executed from SMI handler. Otherwise, when SMI handler ex

Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 10:43, Liran Alon wrote: >>> >>> I think we should also set "vmx->nested.smm.vmxon = false;" >>> after "vmx->nested.vmxon = false;" to correctlyhandle the case >>> VMXOFF is executed from SMI handler. Otherwise, when SMI handler >>> executes RSM, we will reach vmx_pre_leave_smm() whic

Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-22 Thread Dmitry Vyukov
On Wed, Nov 22, 2017 at 10:43 AM, Liran Alon wrote: > > > On 22/11/17 11:31, Wanpeng Li wrote: >> >> 2017-11-22 17:07 GMT+08:00 Liran Alon : >>> >>> >>> >>> On 22/11/17 10:45, Liran Alon wrote: On 22/11/17 09:56, Wanpeng Li wrote: > > > From: Wanpeng Li >

Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-22 Thread Liran Alon
On 22/11/17 11:31, Wanpeng Li wrote: 2017-11-22 17:07 GMT+08:00 Liran Alon : On 22/11/17 10:45, Liran Alon wrote: On 22/11/17 09:56, Wanpeng Li wrote: From: Wanpeng Li Reported by syzkaller: [ cut here ] WARNING: CPU: 5 PID: 2939 at arch/x86/kvm/vmx

Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-22 Thread Wanpeng Li
2017-11-22 17:07 GMT+08:00 Liran Alon : > > > On 22/11/17 10:45, Liran Alon wrote: >> >> >> >> On 22/11/17 09:56, Wanpeng Li wrote: >>> >>> From: Wanpeng Li >>> >>> Reported by syzkaller: >>> >>> [ cut here ] >>> WARNING: CPU: 5 PID: 2939 at arch/x86/kvm/vmx.c:3844

Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-22 Thread Liran Alon
On 22/11/17 10:45, Liran Alon wrote: On 22/11/17 09:56, Wanpeng Li wrote: From: Wanpeng Li Reported by syzkaller: [ cut here ] WARNING: CPU: 5 PID: 2939 at arch/x86/kvm/vmx.c:3844 free_loaded_vmcs+0x77/0x80 [kvm_intel] CPU: 5 PID: 2939 Comm: repro Not t

Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-22 Thread Wanpeng Li
2017-11-22 16:45 GMT+08:00 Liran Alon : > > > On 22/11/17 09:56, Wanpeng Li wrote: >> >> From: Wanpeng Li >> >> Reported by syzkaller: >> >> [ cut here ] >> WARNING: CPU: 5 PID: 2939 at arch/x86/kvm/vmx.c:3844 >> free_loaded_vmcs+0x77/0x80 [kvm_intel] >>

Re: [PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-22 Thread Liran Alon
On 22/11/17 09:56, Wanpeng Li wrote: From: Wanpeng Li Reported by syzkaller: [ cut here ] WARNING: CPU: 5 PID: 2939 at arch/x86/kvm/vmx.c:3844 free_loaded_vmcs+0x77/0x80 [kvm_intel] CPU: 5 PID: 2939 Comm: repro Not tainted 4.14.0+ #26

[PATCH] KVM: VMX: Fix vmx->nested freeing when no SMI handler

2017-11-21 Thread Wanpeng Li
From: Wanpeng Li Reported by syzkaller: [ cut here ] WARNING: CPU: 5 PID: 2939 at arch/x86/kvm/vmx.c:3844 free_loaded_vmcs+0x77/0x80 [kvm_intel] CPU: 5 PID: 2939 Comm: repro Not tainted 4.14.0+ #26 RIP: 0010:free_loaded_vmcs+0x77/0x80 [kvm