Re: [PATCH] KVM: SVM: limit kvm_handle_page_fault to #PF handling

2017-10-11 Thread Brijesh Singh
Hi Paolo, On 10/10/2017 03:49 AM, Paolo Bonzini wrote: ... + +static int npf_interception(struct vcpu_svm *svm) +{ + u64 fault_address = svm->vmcb->control.exit_info_2; + u64 error_code = svm->vmcb->control.exit_info_1; + + trace_kvm_page_fault(fault_address, error_code); +

Re: [PATCH] KVM: SVM: limit kvm_handle_page_fault to #PF handling

2017-10-10 Thread Radim Krčmář
2017-10-10 10:49+0200, Paolo Bonzini: > It has always annoyed me a bit how SVM_EXIT_NPF is handled by > pf_interception. This is also the only reason behind the > under-documented need_unprotect argument to kvm_handle_page_fault. > Let NPF go straight to kvm_mmu_page_fault, just like VMX > does in

[PATCH] KVM: SVM: limit kvm_handle_page_fault to #PF handling

2017-10-10 Thread Paolo Bonzini
It has always annoyed me a bit how SVM_EXIT_NPF is handled by pf_interception. This is also the only reason behind the under-documented need_unprotect argument to kvm_handle_page_fault. Let NPF go straight to kvm_mmu_page_fault, just like VMX does in handle_ept_violation and handle_ept_misconfig.