Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-12 Thread David Howells
Andrew Morton wrote: > James has acked it. I have it queued for processing so it isn't lost. > It has no cc:stable's in it, but David always forgets that ;) Hmmm... I did try and resend it there on the 7th. My mail client records that it did so, but I don't see it in the list archive and I d

Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-11 Thread James Morris
On Mon, 11 Mar 2013, Greg KH wrote: > On Thu, Mar 07, 2013 at 03:59:09PM +1100, James Morris wrote: > > On Wed, 6 Mar 2013, David Howells wrote: > > > > > Reported-by: Mateusz Guzik > > > Signed-off-by: David Howells > > > > Acked-by: James Morris > > What happened to this patch? I don't se

Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-11 Thread Linus Torvalds
On Mon, Mar 11, 2013 at 2:10 PM, Andrew Morton wrote: > On Mon, 11 Mar 2013 14:02:11 -0700 Greg KH wrote: > >> On Thu, Mar 07, 2013 at 03:59:09PM +1100, James Morris wrote: >> > On Wed, 6 Mar 2013, David Howells wrote: >> > >> > > Reported-by: Mateusz Guzik >> > > Signed-off-by: David Howells >

Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-11 Thread Greg KH
On Mon, Mar 11, 2013 at 02:10:32PM -0700, Andrew Morton wrote: > On Mon, 11 Mar 2013 14:02:11 -0700 Greg KH wrote: > > > On Thu, Mar 07, 2013 at 03:59:09PM +1100, James Morris wrote: > > > On Wed, 6 Mar 2013, David Howells wrote: > > > > > > > Reported-by: Mateusz Guzik > > > > Signed-off-by: D

Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-11 Thread Andrew Morton
On Mon, 11 Mar 2013 14:02:11 -0700 Greg KH wrote: > On Thu, Mar 07, 2013 at 03:59:09PM +1100, James Morris wrote: > > On Wed, 6 Mar 2013, David Howells wrote: > > > > > Reported-by: Mateusz Guzik > > > Signed-off-by: David Howells > > > > Acked-by: James Morris > > What happened to this pat

Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-11 Thread Greg KH
On Thu, Mar 07, 2013 at 03:59:09PM +1100, James Morris wrote: > On Wed, 6 Mar 2013, David Howells wrote: > > > Reported-by: Mateusz Guzik > > Signed-off-by: David Howells > > Acked-by: James Morris What happened to this patch? I don't see it in Linus's tree, James, did you pick it up? thank

Re: [PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-06 Thread James Morris
On Wed, 6 Mar 2013, David Howells wrote: > Reported-by: Mateusz Guzik > Signed-off-by: David Howells Acked-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH] KEYS: Fix race with concurrent install_user_keyrings()

2013-03-06 Thread David Howells
This fixes CVE-2013-1792. There is a race in install_user_keyrings() that can cause a NULL pointer dereference when called concurrently for the same user if the uid and uid-session keyrings are not yet created. It might be possible for an unprivileged user to trigger this by calling keyctl() from